Add split and regexp_like functions for different dialects #77
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mikeengland
approved these changes
Oct 25, 2017
pypika/tests/test_functions.py
Outdated
| self.assertEqual("SELECT SPLIT_PART(\"foo\",\'|\',3) FROM \"abc\"", str(q)) | ||
|
|
||
| def test__split_part__field_with_mysql_dialect(self): | ||
| q = QueryBuilder(dialect=Dialects.MYSQL).from_(self.t).select(fn.SplitPart(self.t.foo, '|', 3)) |
There was a problem hiding this comment.
FYI you can use MySQLQuery, PostgreSQL etc classes here instead of QueryBuilder
mikeengland
requested review from
inkmix,
twheys,
aweller,
z-bowen and
wahwynn
x8lucas8x
force-pushed
the
add-split-and-regex-like-functions
branch
from
2a77039 to
2b121e2
Compare
|
@mikeengland Done. Tests are now using the specific QueryBuilders for each dialect. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.