Skip to content

Commit

Permalink
Fix: Convert string to int types for units and failover units
Browse files Browse the repository at this point in the history
  • Loading branch information
kavya498 committed Jul 27, 2021
1 parent a117400 commit d84319a
Show file tree
Hide file tree
Showing 2 changed files with 18 additions and 4 deletions.
4 changes: 2 additions & 2 deletions ibm/data_source_ibm_hpcs.go
Original file line number Diff line number Diff line change
Expand Up @@ -238,10 +238,10 @@ func dataSourceIBMHPCSRead(context context.Context, d *schema.ResourceData, meta
}
if instance.Parameters != nil {
if units, ok := instance.Parameters["units"]; ok {
d.Set("units", units)
d.Set("units", convertInterfaceToInt(units))
}
if failover_units, ok := instance.Parameters["failover_units"]; ok {
d.Set("failover_units", failover_units)
d.Set("failover_units", convertInterfaceToInt(failover_units))
}
}
servicePlan, err := rsCatRepo.GetServicePlanName(instance.ResourcePlanID)
Expand Down
18 changes: 16 additions & 2 deletions ibm/resource_ibm_hpcs.go
Original file line number Diff line number Diff line change
Expand Up @@ -10,6 +10,8 @@ import (
"fmt"
"log"
"os"
"reflect"
"strconv"
"strings"
"time"

Expand Down Expand Up @@ -505,10 +507,10 @@ func resourceIBMHPCSRead(context context.Context, d *schema.ResourceData, meta i
d.Set("service_endpoints", endpoint)
}
if units, ok := instance.Parameters["units"]; ok {
d.Set("units", units)
d.Set("units", convertInterfaceToInt(units))
}
if failover_units, ok := instance.Parameters["failover_units"]; ok {
d.Set("failover_units", failover_units)
d.Set("failover_units", convertInterfaceToInt(failover_units))
}
}
// Set Extensions
Expand Down Expand Up @@ -894,3 +896,15 @@ func hsmClient(d *schema.ResourceData, meta interface{}) (tkesdk.CommonInputs, e

return ci, err
}

func convertInterfaceToInt(raw interface{}) int {
v := reflect.ValueOf(raw)
if v.Kind() == reflect.String {
rawnum, err := strconv.Atoi(raw.(string))
if err != nil {
log.Println("[ERROR] Error converting string to integer")
}
return rawnum
}
return raw.(int)
}

0 comments on commit d84319a

Please sign in to comment.