Skip to content

Commit

Permalink
Fix notebooks context menu (opensearch-project#109)
Browse files Browse the repository at this point in the history
Signed-off-by: Joshua Li <joshuali925@gmail.com>
  • Loading branch information
joshuali925 authored Jul 6, 2021
1 parent b4dcc4b commit 137e784
Showing 1 changed file with 6 additions and 13 deletions.
19 changes: 6 additions & 13 deletions server/routes/report.ts
Original file line number Diff line number Diff line change
Expand Up @@ -93,19 +93,12 @@ export default function (router: IRouter, accessInfo: AccessInfoType) {
// if not deliver to user himself , no need to send actual file data to client
const delivery = report.report_definition.delivery;
addToMetric('report', 'create', 'count', report);
if (
delivery.delivery_type === DELIVERY_TYPE.opensearchDashboardsUser &&
delivery.delivery_params.opensearch_dashboards_recipients.length === 0
) {
return response.ok({
body: {
data: reportData.dataUrl,
filename: reportData.fileName,
},
});
} else {
return response.ok();
}
return response.ok({
body: {
data: reportData.dataUrl,
filename: reportData.fileName,
},
});
} catch (error) {
// TODO: better error handling for delivery and stages in generating report, pass logger to deeper level
logger.error(`Failed to generate report: ${error}`);
Expand Down

0 comments on commit 137e784

Please sign in to comment.