Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix to-many relationships in JPAModule #129

Merged
merged 2 commits into from
Sep 24, 2016

Conversation

reegnz
Copy link
Contributor

@reegnz reegnz commented Sep 22, 2016

When you tried to query a to-many relation it didn't produce a proper result.

Reproduction of the issue is found in JpaRelationshipRepositoryTestBase class.

I had to disable the QueryDSL tests because the QueryFactory for QueryDsl still
cannot handle to-many type of queries properly.

When you tried to query a to-many relation it didn't produce a proper result.

Reproduction of the issue is found in JpaRelationshipRepositoryTestBase class.

I had to disable the QueryDSL tests because the QueryFactory for QueryDsl still
cannot handle to-many type of queries properly.
@coveralls
Copy link

Coverage Status

Coverage remained the same at 89.878% when pulling 10ea37f on adnovum:develop into 05274a2 on katharsis-project:develop.

@reegnz
Copy link
Contributor Author

reegnz commented Sep 22, 2016

Sonar check for the build seems to have failed:
[ERROR] SonarQube server [http://localhost:9000] can not be reached

fixed querydsl integration and added test cases
@coveralls
Copy link

Coverage Status

Coverage increased (+0.06%) to 89.94% when pulling ddfb4bc on adnovum:develop into 05274a2 on katharsis-project:develop.

@remmeier
Copy link
Contributor

fixed query dsl part as well, added some more test cases, created #130 to properly support relationship updates with resource saves.

sonar still broken.

@remmeier remmeier merged commit 2adb4db into katharsis-project:develop Sep 24, 2016
@masterspambot
Copy link
Member

👍

On Sat, 24 Sep 2016, 21:49 Remo, notifications@github.com wrote:

Merged #129
#129.


You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub
#129 (comment),
or mute the thread
https://github.com/notifications/unsubscribe-auth/AAjeAdyVUsmWdEx5hIb-BGKweACpfA63ks5qtX6zgaJpZM4KD1xr
.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants