QuerySpec API to simplify QueryParameters handling #104
Conversation
parameters #4 prototype of a new QueryParams class named QuerySpec to ease use. Integrated as BaseResourceRepository and BaseRelationshipRepository providing an adapter from QueryParams to QuerySpec. - just a prototype, not yet functional - APi oriented towards the queries resource, parameters for other types can be obtained from QuerySpec.relatedSpecs. - QuerySpecParser will be used to sort out what is a type, operator and attribute path. - InMemoryEvaluator to apply a QuerySpec to a list in memory for simple use cases
| @@ -16,9 +16,6 @@ | |||
| */ | |||
| public class ClassUtils { | |||
There was a problem hiding this comment.
There is a whole lost percent of coverage. That is somewhat troubling
On Fri, Sep 2, 2016, 8:11 AM SonarQube Reporter notifications@github.com
wrote:
In katharsis-core/src/main/java/io/katharsis/utils/ClassUtils.java
#104 (comment)
:@@ -16,9 +16,6 @@
*/
public class ClassUtils {[image: MAJOR]
https://raw.githubusercontent.com/SonarCommunity/sonar-github/master/images/severity-major.png
Add a private constructor to hide the implicit public one. [image: rule]
https://sonarqube.com/coding_rules#rule_key=squid%3AS1118—
You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub
https://github.com/katharsis-project/katharsis-framework/pull/104/files/4621aac399372494c3dcdb12e77d4947ccdd94d7#r77362114,
or mute the thread
https://github.com/notifications/unsubscribe-auth/ABaI0Dj3XhHOOat-2ssl7eEMUBnvMmIYks5qmDwogaJpZM4Jy4e0
.
|
will have a look at the sonar coverage... |
|
Would be really nice to get documentation for this. This feature is in 2.6.0, but without documentation, it's not very useful. See #109 @remmeier @masterspambot If you could just throw something together, I'd be happy to polish it up. |
- proper total count computation - support to traverse multi-valued properties
- proper total count computation - support to traverse multi-valued properties
see #4
New QuerySpec class and QuerySpecResourceRepository to take care of QueryParams parsing and providing a higher-level API.
QuerySpec.apply() to perform in-memory operations.