Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade to Ember 4.8 and use Ember Octane syntax. #128

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

dysonic
Copy link

@dysonic dysonic commented Apr 3, 2023

This is my first time doing this so fingers crossed. The main changes are to upgrade to Ember 4.8 and use Ember Octane syntax. I couldn't get Ember try to work as it was getting errors:

ember try:one ember-lts-3.28 --- ember serve
Error!
Error: Cannot copy '../../../browserslist/cli.js' to a subdirectory of itself, '../../../browserslist/cli.js'.
Error: Cannot copy '../../../browserslist/cli.js' to a subdirectory of itself, '../../../browserslist/cli.js'.
    at /data/git/dysonic/ember-feature-flags/node_modules/ember-try/node_modules/fs-extra/lib/copy/copy.js:210:21
    at FSReqCallback.oncomplete (node:fs:188:23)

But I am assuming it should all be good. All the Ember tests passed. This is so the add on remains up to date, and to remove deprecation messages whilst using it.

@elgordino
Copy link

Just a note to say I am now using this commit in my project and it's working as expected. A note to anyone else trying, be sure to read the update in the README.

Thanks very much for putting this together. As a community user of this addon I would support this merge. Thanks.

Copy link

@Baltazore Baltazore left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the work on it, I'll try to use it in my app from this branch

README.md Outdated Show resolved Hide resolved
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants