Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix start time of llm filter #278

Merged
merged 2 commits into from
Nov 18, 2024
Merged

fix start time of llm filter #278

merged 2 commits into from
Nov 18, 2024

Conversation

adilhafeez
Copy link
Contributor

No description provided.

@adilhafeez adilhafeez marked this pull request as ready for review November 18, 2024 00:44
salmanap
salmanap approved these changes Nov 18, 2024
View reviewed changes
Copy link
Contributor

@salmanap salmanap left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do we need to add tests for this?

@adilhafeez
Copy link
Contributor Author

adilhafeez commented Nov 18, 2024 •
edited
Loading

Do we need to add tests for this?

yes we do, it should be captured in e2e tests

filed issue #279

@adilhafeez adilhafeez merged commit 097513e into main Nov 18, 2024
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@salmanap salmanap salmanap approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@adilhafeez @salmanap