retry embeddings fetch #245
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cotran2
requested changes
Nov 5, 2024
| @@ -332,7 +333,7 @@ llm_providers: | |||
|
|
|||
| overrides: | |||
| # confidence threshold for prompt target intent matching | |||
| prompt_target_intent_matching_threshold: 0.6 | |||
| prompt_target_intent_matching_threshold: 0.0 | |||
There was a problem hiding this comment.
this is for testing, I changed nan -> 0.0 when embeddings is not found. So had to lower the threshold so we go to weather endpoint
| @@ -234,7 +245,7 @@ impl StreamContext { | |||
| "description embeddings not found for prompt target name: {}", | |||
| prompt_name | |||
| ); | |||
| return (prompt_name.clone(), f64::NAN); | |||
| return (prompt_name.clone(), 0.0); | |||
There was a problem hiding this comment.
why return 0.0 instead of nan?
There was a problem hiding this comment.
0 tells there is no similarity, this only happens when embeddings are not found
cotran2
approved these changes
Nov 5, 2024
salmanap
approved these changes
Nov 5, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Updated arch gateway code to not panic if embedding server is not up yet. Rather it will keep on trying.
This code change fixes #247 and #243