Delete example code, and move prod code into functional separation #16
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: José Ulises Niño Rivera <junr03@users.noreply.github.com>
adilhafeez
approved these changes
Jul 19, 2024
adilhafeez
reviewed
Jul 19, 2024
envoyfilter/src/lib.rs
Outdated
| } | ||
| } | ||
|
|
||
| fn embedding_request_worker( |
There was a problem hiding this comment.
name could be embedding_request_handler as its not a background thread
There was a problem hiding this comment.
I like this. I took inspiration from Envoy conventions. But really, you are right -- and tbh I never liked that convention that much 😂
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR deletes all the previous filter code that served as a working example and only leaves the production code for the Katanemo gateway. The only exception is the stats code.
This refactor also prepares the code to be unit tested by separating functionality into small functions.
I have a subsequent PR that starts investigating mocking proxy_wasm::host_calls. The main problem is that the linker still expects the extern C functions when compiling tests.