Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add testing to GitHub workflow #15

Merged
merged 6 commits into from
Jul 18, 2024
Merged

Add testing to GitHub workflow #15

merged 6 commits into from
Jul 18, 2024

Conversation

aayushwhiz
Copy link
Contributor

Adds in a test action to workflow and updates pre-commit to use --lib since in traditional rust project structure, unit tests are in the library crate and integration tests are in a separate tests directory and --lib will only run the tests in the library crate which are supposed to be unit tests.

@aayushwhiz aayushwhiz requested a review from adilhafeez July 18, 2024 20:20
.pre-commit-config.yaml Outdated Show resolved Hide resolved
aayushwhiz and others added 2 commits July 18, 2024 14:06
Co-authored-by: Adil Hafeez <adil@katanemo.com>
Co-authored-by: Adil Hafeez <adil@katanemo.com>
Copy link
Contributor

@adilhafeez adilhafeez left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

pls address the suggestions first before merge

@aayushwhiz aayushwhiz merged commit 31c4ac2 into main Jul 18, 2024
3 checks passed
@junr03 junr03 deleted the update-workflow-for-test branch September 5, 2024 00:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants