Skip to content
This repository has been archived by the owner on Jun 28, 2024. It is now read-only.

add cmd/check-markdown/kata-check-markdown to .gitignore #4790

Closed
liubin opened this issue May 16, 2022 · 2 comments · Fixed by #5499
Closed

add cmd/check-markdown/kata-check-markdown to .gitignore #4790

liubin opened this issue May 16, 2022 · 2 comments · Fixed by #5499
Assignees
Labels
bug Incorrect behaviour good-first-issue Small and simple task for new contributors

Comments

@liubin
Copy link
Member

liubin commented May 16, 2022

After running ./.ci/static-checks.sh --docs there will be a file named cmd/check-markdown/kata-check-markdown remained.

@liubin liubin added bug Incorrect behaviour good-first-issue Small and simple task for new contributors needs-review Needs to be assessed by the team. labels May 16, 2022
@wainersm wainersm self-assigned this Jun 15, 2022
@jodh-intel
Copy link
Contributor

@wainersm - are you still looking at this? If not, could I possibly hijack it and give it to one of our outreach students?

@jodh-intel jodh-intel removed the needs-review Needs to be assessed by the team. label Feb 17, 2023
@jodh-intel
Copy link
Contributor

@Toreseen - if you do this, you'll need to:

$ git clone https://github.com/kata-containers/tests
$ git remote add Toreseen-github https://github.com/Toreseen/tests
$ git checkout -b update-gitignore

Then,

  • Browse to https://github.com/kata-containers/tests and click "fork".
  • Run the command @liubin has specified above.
  • Check that the output of git status shows cmd/check-markdown/kata-check-markdown.
  • Modify the top-level .gitignore to add cmd/check-markdown/kata-check-markdown.
  • Re-run git status and ensure that cmd/check-markdown/kata-check-markdown is no longer shown.

Then,

$ git commit -as
$ git push -f Toreseen-github

Toreseen added a commit to Toreseen/tests that referenced this issue Mar 1, 2023
.gitignore has been updated to contain the line "cmd/check-markdown/kata-check-markdown".

Fixes kata-containers#4790

Signed-off-by: Maxwell Wendlandt <maxjman101@gmail.com>
Toreseen added a commit to Toreseen/tests that referenced this issue Mar 1, 2023
.gitignore has been updated to contain the line "cmd/check-markdown/kata-check-markdown".

Fixes kata-containers#4790

Signed-off-by: Maxwell Wendlandt <maxjman101@gmail.com>
fitzthum pushed a commit to fitzthum/tests that referenced this issue Mar 21, 2023
.gitignore has been updated to contain the line "cmd/check-markdown/kata-check-markdown".

Fixes kata-containers#4790

Signed-off-by: Maxwell Wendlandt <maxjman101@gmail.com>
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
bug Incorrect behaviour good-first-issue Small and simple task for new contributors
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants