-
Notifications
You must be signed in to change notification settings - Fork 375
Implement the runc events command #186
Comments
@WeiZhang555 @jodh-intel |
@jshachm Please go ahead! If anyone is already working on this, please let us know to avoid waste of someone's work 😄 |
As per clearcontainers/runtime#379, I'd be really happy to see a rough idea of what we can/will support and how first. Sure, that can be via an RFC PR, or just scribble some stuff down here for us to discuss :-) |
@grahamwhaley Thanks! @jshachm is my colleague so I will push him on this, and make sure this can be done before release 1.0.0! |
I agree with @grahamwhaley, a proposal to explain what you plan doing (as a comment of this Github issue) should be the starting point. It's not worth spending time on the implementation if we don't agree on how to proceed first ;) |
@sboeuf @grahamwhaley |
Hi @jshachm I'll let @sboeuf comment on the StatsContainer API etc. |
Nice -- I wonder if we should rephrase this issue to something more like, "support CRI core metrics". Or, "make kata work with prometheus" -- I think this is the more important gap that we have in this area. Let me know if I'm missing the idea, though -- I haven't looked into runc events CLI before. This has been on my radar for a while as an important enabling for Kata in the ecosystem, and saw this as a post release activity. If we have dedicated head to look into this now, then I'm very happy! A couple of relevant pointers: @tallclair , FYI, as this is something we've discussed briefly in the past. |
Can we avoid renaming this issue unless we also update the limitations doc (kata-containers/documentation#48) which references it. |
@jshachm @grahamwhaley @jodh-intel I was looking into
|
@sboeuf tough day today and now finally have time to take a closer look at your suggestions.
I can't agree more on this point and this is what my local codes is being organized.
yeap, just a function like Good detail analysis. Thx a lot. @grahamwhaley as you said if |
First RFC pr will be adding api in |
Add a template to guide the user on raising github issues. Fixes kata-containers#186. Signed-off-by: James O. D. Hunt <james.o.hunt@intel.com>
Originally raised as clearcontainers/runtime#379.
The text was updated successfully, but these errors were encountered: