This repository has been archived by the owner on May 12, 2021. It is now read-only.
uevent: Fix netlink error while assigning pid in netlink client #217
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sboeuf
approved these changes
Apr 20, 2018
jodh-intel
reviewed
Apr 23, 2018
pkg/uevent/uevent.go
Outdated
| @@ -35,7 +34,7 @@ type ReaderCloser struct { | |||
| func NewReaderCloser() (io.ReadCloser, error) { | |||
| nl := unix.SockaddrNetlink{ | |||
| Family: unix.AF_NETLINK, | |||
| Pid: uint32(os.Getpid()), | |||
| Pid: uint32(0), | |||
There was a problem hiding this comment.
I appreciate you've documented this in the commit, but I'd also be tempted to put a comment above this line as it looks "odd" ;)
unix.SockaddrNetlink represents a netlink client with the Pid being the netlink socket address. This can be assigned the actual pid of the process, but in case we have two netlink sockets opened at the same time, this results in errors in binding to the netlink socket. Assign this to zero which means the kernel takes care of assigning it. See http://man7.org/linux/man-pages/man7/netlink.7.html Fixes kata-containers#216 Signed-off-by: Archana Shinde <archana.m.shinde@intel.com>
amshinde
force-pushed
the
fix-uevent-error
branch
from
bc9d12c
to
8f828bb
Compare
Codecov Report
@@ Coverage Diff @@
## master #217 +/- ##
=======================================
Coverage 40.05% 40.05%
=======================================
Files 12 12
Lines 1790 1790
=======================================
Hits 717 717
Misses 971 971
Partials 102 102Continue to review full report at Codecov.
|
|
lgtm |
|
lgtm! |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
unix.SockaddrNetlink represents a netlink client with the Pid
being the netlink socket address. This can be assigned the actual
pid of the process, but in case we have two netlink sockets opened
at the same time, this results in errors in binding to the netlink
socket. Assign this to zero which means the kernel takes care of
assigning it.
See http://man7.org/linux/man-pages/man7/netlink.7.html
Fixes #216
Signed-off-by: Archana Shinde archana.m.shinde@intel.com