This repository has been archived by the owner on May 12, 2021. It is now read-only.
implement mockreaper for unit testing #207
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 2 commits
April 4, 2018 10:58
All reaper implementations must override its functions. This new interface allows the creation of mock reapers that are useful for unit testing. Signed-off-by: Julio Montes <julio.montes@intel.com>
mockreaper is a helpful struct to write unit tests fixes kata-containers#208 Signed-off-by: Julio Montes <julio.montes@intel.com>
Codecov Report
@@ Coverage Diff @@
## master #207 +/- ##
==========================================
+ Coverage 32.05% 33.33% +1.28%
==========================================
Files 10 11 +1
Lines 1482 1599 +117
==========================================
+ Hits 475 533 +58
- Misses 940 986 +46
- Partials 67 80 +13
Continue to review full report at Codecov.
|
|
lgtm |
sboeuf
approved these changes
Apr 6, 2018
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.