Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Removed google.maps.marker, using AdvancedMarker intead. #8

Merged
merged 4 commits into from
Apr 29, 2024
Merged

Conversation

kashaudhan
Copy link
Owner

Using AdvancedMarker as suggested by google.maps

  1. Removed custom icon option props
  2. Removed alwaysCentered props

Copy link

gitguardian bot commented Apr 29, 2024

⚠️ GitGuardian has uncovered 4 secrets following the scan of your pull request.

Please consider investigating the findings and remediating the incidents. Failure to do so may lead to compromising the associated services or software components.

🔎 Detected hardcoded secrets in your pull request
GitGuardian id GitGuardian status Secret Commit Filename
6790726 Triggered Google API Key 454017a README.md View secret
6790726 Triggered Google API Key 454017a example/App.tsx View secret
6790726 Triggered Google API Key 454017a README.md View secret
6790726 Triggered Google API Key 454017a example/App.tsx View secret
🛠 Guidelines to remediate hardcoded secrets
  1. Understand the implications of revoking this secret by investigating where it is used in your code.
  2. Replace and store your secrets safely. Learn here the best practices.
  3. Revoke and rotate these secrets.
  4. If possible, rewrite git history. Rewriting git history is not a trivial act. You might completely break other contributing developers' workflow and you risk accidentally deleting legitimate data.

To avoid such incidents in the future consider


🦉 GitGuardian detects secrets in your source code to help developers and security teams secure the modern development process. You are seeing this because you or someone else with access to this repository has authorized GitGuardian to scan your pull request.

Our GitHub checks need improvements? Share your feedbacks!

@kashaudhan kashaudhan merged commit 52068ee into main Apr 29, 2024
1 of 11 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant