Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Rename Widget::spatial_nav → nav_next and auto-implement #345

Merged
merged 11 commits into from
Aug 10, 2022
Merged

Rename Widget::spatial_nav → nav_next and auto-implement #345

merged 11 commits into from
Aug 10, 2022

Conversation

dhardy
Copy link
Collaborator

@dhardy dhardy commented Aug 9, 2022

No description provided.

@dhardy dhardy marked this pull request as ready for review August 9, 2022 15:22
@dhardy
Copy link
Collaborator Author

dhardy commented Aug 10, 2022

Add:

  • non_navigable modifier to layout = ..; property of #[widget]
  • Autogenerate Widget::nav_next from layout = ..; property

Renames:

  • Widget::key_nav → Widget::navigable — this is not only keyboard navigation since focus can be set via mouse click
  • Widget::spatial_nav → Widget::nav_next — could have been nav_order, but

Fix:

  • Do not trigger accelerator keys with Ctrl/Shift/Logo modifier

Doc:

  • Improve doc for layout = ..; property of #[widget]

@dhardy dhardy merged commit 84a814c into master Aug 10, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@dhardy