Rename things #330
Merged
Rename things #330
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Rationale: consistency. 'checkbox' arguably works as one word, not 'radiobox'; similarly 'scrollbar' might but 'progressbar' does not.
It already appears in the public API of the Colors struct
This places it next to its reverse, find_child_index. Based on usage, WidgetChildren appears to always be implemented when this method is explicitly implemented.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This attempts to address some less-than-ideal names, before such changes would break too many user's code.
scrollbar,ScrollBar). Arguably "scrollbar" might be considered a word today, but consistency is important and "progressbar" is definitely not.CheckBoxtoCheckButton(with label) andCheckBoxBaretoCheckBox(without label). Do the same forRadioBox*.RadioBoxGrouptoRadioGroupSetRectMgrtoConfigMgr: it's a special type used when configuring things (Widget::configure,Layout::set_rect,Layout::spatial_nav). No obvious perfect choice.There are still some widgets with non-typical names where it was decided to keep these:
EditBox,EditField(same without the box): other frameworks might call theseInput,TextInput,TextEdit,EditText,Entry(there's actually not much consistency here). Some of these names are only for single/multi-line widgets; our widget supports both modes. We also have an associated trait,EditGuard, which fits well with the current names.TabStackis a descriptive name: a stack with tabs (compareTabs, Qt'sTabWidgetor GTK'sNotebook).DragHandlemight be better namedGripor something... in any case, it's not a widely used widget.Finally:
Widget::make_child_idtoWidgetChildren, which already houses the "reverse" method,find_child_index. Current widgets with non-default implementations all implementWidgetChildrendirectly already.