Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Trait revision part 1: #312

Merged
merged 19 commits into from
May 3, 2022
Merged

Trait revision part 1: #312

merged 19 commits into from
May 3, 2022

Conversation

dhardy
Copy link
Collaborator

@dhardy dhardy commented May 3, 2022

  • Move kas::event::Handler methods into Widget; remove Handler trait
  • Move kas::WidgetConfig methods into Widget; remove WidgetConfig trait
  • Support merging properties defined via #[widget] attribute into Widget implementation and to override methods generated by derive
  • Move some Layout methods to Widget trait: translation, spatial_nav, find_id
  • Update kas-text: Breaking: return Result<T, NotReady> instead of panic kas-text#65
  • Remove List::size_solved flag: do not inhibit drawing between adding new widgets and calling set_rect
  • DrawMgr::with_clip_region and with_overlay: change closure type to FnOnce
  • Add WidgetId field to DrawMgr; remove parameter from Component::draw
  • Replace some explicit impls of Layout::layout (method is to be removed in the future)

Revision of the Layout trait is cut short here, but this PR is already large enough.

@dhardy dhardy merged commit 8f2e69e into master May 3, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant