Restore configure_recurse; use local reconfigure for dynamic parents #299
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
List,Stack,ComboBoxandSplitterwidgets now locally reconfigure new children without changing theWidgetIdof other children (they use aHashMapforWidgetId→child_indexlookup).The result (using
example/data-list.rsand a hand-controlled stopwatch):Full-window resize is still required after adjusting the number of widgets, but apparently this is clearly much faster than configuring widgets (a little surprising since configuring is mostly just assigning a
WidgetId).TODO:
ComboBoxdoesn't need to resize the window if the menu is closed, and only needs to resize the menu if open, but it inherits the full-window resize fromList. (Low impact optimisation so I'll leave it.)