update deps, add widget_index!, improve examples/markdown #291
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dhardy
commented
Mar 4, 2022
Comment on lines
+59
to
+63
| fn visit_macro_mut(&mut self, node: &mut syn::Macro) { | ||
| // HACK: we cannot expand the macro here since we do not have an Expr | ||
| // to replace. Instead we can only modify the macro's tokens. | ||
| // WARNING: if the macro's tokens are modified before printing an error | ||
| // message is emitted then the span of that error message is incorrect. |
There was a problem hiding this comment.
Yes, this is a bit hacky, but still works well enough. The only alternative (as far as I am aware) would be to match one level up, which would require matching both expressions and patterns (and maybe more) to catch everywhere the macro might be used.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
examples/markdown.rs: remove button and update on typingwidget_index!macro for use withinwidget!macro