Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The intention here is to allow themes like
ShadedTheme
to be incomplete by providing some base implementation to fill in missing methods. CurrentlyShadedTheme
does effectively the same thing but with stub functions; part of the point of this change is to make it non-breaking (or less breaking) to extendDrawHandle
andSizeHandle
.Blocker:
Fixing this would need some form of specialisation or negative trait bounds (e.g. rust-lang/rfcs/issues/1834).
An alternative would be to add the
base*
methods and default implementations toDrawHandle
itself; this is less desirable since themes without a base (e.g.FlatTheme
) would be forced to panic in thebase*
methods, resulting in run-time failure if the theme is incomplete (and only then on examples which use those size/draw methods).Incomplete in this PR:
ShadedTheme
to implDerivedDrawHandle
DerivedSizeHandle