Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add ARM64 Build #329

Merged
merged 1 commit into from
Sep 15, 2021
Merged

Add ARM64 Build #329

merged 1 commit into from
Sep 15, 2021

Conversation

flyingjoe
Copy link
Contributor

This adds an ARM64 build to the deploy-image action to enable running it natively on a M1 Mac (#301 ) .

@lucernae
Copy link
Contributor

Hi @flyingjoe , thanks for the PR.
Can you help us by explaining more on how to use the arm64 build on an M1 Mac?
If you use docker on M1 Mac, will it pull arm64 build automatically or does it need specific command to do that?

@flyingjoe
Copy link
Contributor Author

Hi @lucernae,
docker always checks if the image is available for the right architecture and will pull that one per default.
So for running the arm64 version on a M1 Mac, there is no need to change anything.
If someone still wanted to use the amd64 version he'd need to use the platform option in compose or docker-cli:
Compose: https://github.com/docker/docker.github.io/blob/master/compose/compose-file/compose-file-v2.md#platform
CLI: https://docs.docker.com/engine/reference/commandline/run/#options

@lucernae
Copy link
Contributor

Thanks @flyingjoe.
What do you think @NyakudyaA ?
I think we can merge this. The build test succeed and the change is just on the action.yaml file. No harm in merging this.
LGTM.

@NyakudyaA
Copy link
Collaborator

Thanks @flyingjoe.
What do you think @NyakudyaA ?
I think we can merge this. The build test succeed and the change is just on the action.yaml file. No harm in merging this.
LGTM.

I think we can merge this @lucernae

@NyakudyaA NyakudyaA merged commit ce13cdc into kartoza:develop Sep 15, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants