Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix double quote replace in csv export #415

Merged
merged 1 commit into from
Dec 29, 2015
Merged

Fix double quote replace in csv export #415

merged 1 commit into from
Dec 29, 2015

Conversation

vladdnepr
Copy link

Hi.
Fix CSV export

Here is sample code:

'Lorem "Ipsim"'.replace('"', '""')
< Lorem ""Ipsim"
'Lorem "Ipsim"'.replace(/"/g, '""')
< Lorem ""Ipsim""

Last code work correctly

@kartik-v kartik-v added the bug label Dec 29, 2015
kartik-v added a commit that referenced this pull request Dec 29, 2015
@kartik-v
Merge pull request #415 from vladdnepr/csv_export_quote_fix
aeeb78e 
Fix double quote replace in csv export
@kartik-v kartik-v merged commit aeeb78e into kartik-v:master Dec 29, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
bug
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@vladdnepr @kartik-v