Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

project-x on MEPLA #5

Open
manufactory opened this issue Nov 16, 2021 · 12 comments
Open

project-x on MEPLA #5

manufactory opened this issue Nov 16, 2021 · 12 comments

Comments

@manufactory
Copy link

Hello,

Is there any specific reason why project-x is not available on MEPLA? If you have nothing against it, I'd be happy to create recipe and open a PR to get it added :)

@karthink
Copy link
Owner

karthink commented Nov 17, 2021

Hey @manufactory,

I was initially hesitant to submit this to MELPA since project.el is being actively developed and thus project-x might break often. However there have been no breaking changes since I wrote it, so it might be a good idea to do so now. I don't have the time for this at the moment, but feel free to submit it to MELPA if you're interested. The code will need to be linted to pass the MELPA review, I can make you a co-author if you're okay with doing that.

What do you think?

EDIT: You can also submit the linted version as a PR I guess.

@manufactory
Copy link
Author

Hey,

Thanks! I ran all the linters suggested by MELPA and they found no issues.

When going through the code, the only thing that I noticed is that (project-root) can be replaced by (project-root) provided by project.el.

I found an issue when playing around: Projects (sometimes?) don't get recognized when there's a .project file in the main directory. My test case is quite simple: I created a directory, ~/tmp/project-x-test, containing two files and an empty .project file, invoked (project-x-mode) and the project directory is always my home directory, not ~/tmp/project-x-test.
I'm also quite busy, but perhaps I find some time to look into that. It might just be the order in which packages or hooks are loaded. I'll keep you posted :)

@kingcons
Copy link

Any update on this? It would be lovely to see this package available publicly. I may be able to look into it in the next week or two if you're both busy. :)

@manufactory
Copy link
Author

I'm currently to busy to work on this, so if @karthink is fine with it go ahead :)

@karthink
Copy link
Owner

karthink commented Jan 25, 2022 via email

@trev-dev
Copy link

I volunteer to submit it, @manufactory

@karthink
Copy link
Owner

@trev-dev Thanks. Before submission, it might be a good idea to update the package for Emacs 29, since the latest project.el has changed a bit. Nothing's broken in project-x (as best I can tell), but project.el has gained some of project-x's features, such as the ability to identify projects based on the existence of a special file in the root directory of the project.

I'm not on 29 yet so I haven't looked into it.

@trev-dev
Copy link

Funny, as the main reason I want project-x is for that project root feature. Emacs as a graphical program is a tad annoying to set up with the proper context.

Do you suspect that Emacs 29 will essentially deprecate project-x?

@karthink
Copy link
Owner

karthink commented Apr 27, 2023 via email

@trev-dev
Copy link

trev-dev commented May 4, 2023

Apologies @karthink, but due to reasons not in your control I'm moving on from Emacs for now.

@orazdow
Copy link

orazdow commented Feb 4, 2024

This is a great package, I think it should go on melpa. I'm pretty new to emacs so I can't do a pr for it though unfortunately. Btw I'm on 29.2 and it works well.

@karthink
Copy link
Owner

karthink commented Feb 5, 2024 via email

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

5 participants