Skip to content

Commit

Permalink
gptel-transient: Avoid clashes with the custom directive key (#219)
Browse files Browse the repository at this point in the history
gptel-transient (gptel--system-prompt-setup): When assigning keys
to directives, avoid clashes with the system-message edit key
(`h`), and use an arbitrary unused key if no mnemonic key
assignments are possible.
  • Loading branch information
martenlienen authored Feb 28, 2024
1 parent 8ba07d0 commit 149261e
Showing 1 changed file with 5 additions and 9 deletions.
14 changes: 5 additions & 9 deletions gptel-transient.el
Original file line number Diff line number Diff line change
Expand Up @@ -185,22 +185,18 @@ which see."
(transient-parse-suffixes
'gptel-system-prompt
(cl-loop for (type . prompt) in gptel-directives
with taken
;; Avoid clashes with the custom directive key
with unused-keys = (delete ?h (number-sequence ?a ?z))
with width = (window-width)
for name = (symbol-name type)
for key =
(let ((idx 0) pos)
(while (or (not pos) (member pos taken))
(setq pos (substring name idx (1+ idx)))
(cl-incf idx))
(push pos taken)
pos)
for key = (seq-find (lambda (k) (member k unused-keys)) name (seq-first unused-keys))
do (setq unused-keys (delete key unused-keys))
;; The explicit declaration ":transient transient--do-return" here
;; appears to be required for Transient v0.5 and up. Without it, these
;; are treated as suffixes when invoking `gptel-system-prompt' directly,
;; and infixes when going through `gptel-menu'.
;; TODO: Raise an issue with Transient.
collect (list (key-description key)
collect (list (key-description (list key))
(concat (capitalize name) " "
(propertize " " 'display '(space :align-to 20))
(propertize
Expand Down

0 comments on commit 149261e

Please sign in to comment.