Skip to content

Commit

Permalink
Fix build error in abfs test (facebookincubator#9577)
Browse files Browse the repository at this point in the history
Summary:
Fix CI failure in [Linux Build / Linux release with adapters (pull_request)](https://github.com/facebookincubator/velox/actions/runs/8793602118/job/24131750229?pr=9478):
```
/__w/velox/velox/./velox/connectors/hive/storage_adapters/abfs/tests/MockBlobStorageFileClient.h:30:27: error: 'using element_type = class facebook::velox::exec::test::TempFilePath' {aka 'class facebook::velox::exec::test::TempFilePath'} has no member named 'path'; did you mean 'const string facebook::velox::exec::test::TempFilePath::path_'? (accessible via 'const string& facebook::velox::exec::test::TempFilePath::getPath() const')
   30 |     filePath_ = tempFile->path;
      |                           ^~~~
      |                           getPath()

```

```
/__w/velox/velox/velox/connectors/hive/storage_adapters/abfs/tests/AbfsFileSystemTest.cpp:69:38: error: 'using element_type = class facebook::velox::exec::test::TempFilePath' {aka 'class facebook::velox::exec::test::TempFilePath'} has no member named 'path'; did you mean 'const string facebook::velox::exec::test::TempFilePath::path_'? (accessible via 'const string& facebook::velox::exec::test::TempFilePath::getPath() const')
   69 |     azuriteServer->addFile(tempFile->path, filePath);
      |                                      ^~~~
      |                                      getPath()
```

Pull Request resolved: facebookincubator#9577

Reviewed By: bikramSingh91

Differential Revision: D56471534

Pulled By: Yuhta

fbshipit-source-id: 99bfe31590d346e4140820a5d1bdbb72e0660410
  • Loading branch information
zhli1142015 authored and facebook-github-bot committed Apr 23, 2024
1 parent ba8253b commit a362a67
Show file tree
Hide file tree
Showing 2 changed files with 2 additions and 2 deletions.
Original file line number Diff line number Diff line change
Expand Up @@ -66,7 +66,7 @@ class AbfsFileSystemTest : public testing::Test {
azuriteServer = std::make_shared<filesystems::test::AzuriteServer>(port);
azuriteServer->start();
auto tempFile = createFile();
azuriteServer->addFile(tempFile->path, filePath);
azuriteServer->addFile(tempFile->getPath(), filePath);
}

void TearDown() override {
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -27,7 +27,7 @@ class MockBlobStorageFileClient : public IBlobStorageFileClient {
public:
MockBlobStorageFileClient() {
auto tempFile = ::exec::test::TempFilePath::create();
filePath_ = tempFile->path;
filePath_ = tempFile->getPath();
}

void create() override;
Expand Down

0 comments on commit a362a67

Please sign in to comment.