-
Notifications
You must be signed in to change notification settings - Fork 177
Conversation
As it used to be. Also defaults place edit map to be group centre if available.
"sync: false" seems to be the new way it goes and will be the default in the future, see vuejs/vue-test-utils#1137 The transition group stubs seem to be there by default now too, I think.. Anyway it works where it did no tbefore :) Also see vuejs/vue-test-utils#1163
Not really sure why this changed, but don't want to think about it for now...
Codecov Report
@@ Coverage Diff @@
## master #1878 +/- ##
==========================================
- Coverage 60.36% 60.23% -0.13%
==========================================
Files 268 268
Lines 5540 5537 -3
Branches 841 841
==========================================
- Hits 3344 3335 -9
- Misses 2195 2201 +6
Partials 1 1
Continue to review full report at Codecov.
|
Test failures were a bit weird, unrelated to my changes, but fixed now. |
I had a quick try, UI seems good; definitely better than before. Will have a detailed look later into code and wording! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Left two comments.
Aside, I wonder if we should rewrite v-slot:
to #
to keep it uniform?
Yes, I would like that, seems neater and consistent with generally using short versions where possible. |
* Use address autocomplete As it used to be. Also defaults place edit map to be group centre if available. * Remove uneeded extra wrapped div * Update setup for storyshots testing "sync: false" seems to be the new way it goes and will be the default in the future, see vuejs/vue-test-utils#1137 The transition group stubs seem to be there by default now too, I think.. Anyway it works where it did no tbefore :) Also see vuejs/vue-test-utils#1163 * Add @types/jest - for editor support See https://blog.jetbrains.com/webstorm/2018/10/testing-with-jest-in-webstorm/ * Increase test wait Not really sure why this changed, but don't want to think about it for now... * Add text to translation file * Use the spelling of the enemy * Simplify template logic
* Initial work to add person-to-person sharing * A few sharing item UI refinements * Initial new sharing form with multiple upload * Add a grey box... * Remove redundant check * Rename sharing to offers * Add a mock chat to offer detail UI * Create mobile version of offer detail UI * Tidy up multiple image editing * A bit more polish on the offer UI Some translations, icon, breadcrumb, etc... * Snapshot update * Add create offer breadcrumb title * Rename a few offer related things for consistency * Offer image carousel, multi upload, various bits * Refine image upload/remove/re-position * Add websocket listeners for offer changes * Wireup offer conversation * Basic features to allow to accept/archive offers * Remove uneeded demo data * Move selected offer data/logic to own store module * Preserve offer filter in more places The create/save filter preservation does not work actually as we clear the store contents on route change. * Remove status from offer form Status change is now done via explicit actions/buttons * Use address autocomplete (#1878) * Use address autocomplete As it used to be. Also defaults place edit map to be group centre if available. * Remove uneeded extra wrapped div * Update setup for storyshots testing "sync: false" seems to be the new way it goes and will be the default in the future, see vuejs/vue-test-utils#1137 The transition group stubs seem to be there by default now too, I think.. Anyway it works where it did no tbefore :) Also see vuejs/vue-test-utils#1163 * Add @types/jest - for editor support See https://blog.jetbrains.com/webstorm/2018/10/testing-with-jest-in-webstorm/ * Increase test wait Not really sure why this changed, but don't want to think about it for now... * Add text to translation file * Use the spelling of the enemy * Simplify template logic * Ffix multicroppa * Further refine offer editing, esp MultiCroppa * Use gift as offers menu item * Remove offer upload progress logging * Nicer create offer button * Clear offerDetail on route leave * Add offer list loading indicator * Add offer body loading indicator * Add loading spinner when fetching offer for edit * Correctly wire up offer form reset events * Only show offer accept/archive buttons if active * Handle updating offers after save/websocket better * Cleaner mobile form view * Only show carousel if >1 image * Fix offer header when name is very long * Fix offer detail image display when only 1 * Fix overflowing text on group offers page * White background offer description * Snapshot update * Don't try and be fancy with updating users * Fix style style * Hide offers if group does not have the feature * Check route features in after route hook * Actually filter offers by current group * Add offers covert function to convert createdAt * Display offer information in latest messages I did it a slightly different way, by adding related offers into the latestMessages state... * Keep related offers up to date via websocket It's a bit overkeen actually as most users won't be in the conversations for the offers, so we don't need to update the related item... should really check we need it first * Import default offer status from store * Use current route query instead of getter * Use + for new offer button * Allow setting new_offer notification types * Show offer status if not active Although it's a bit ugly * Change notification type spinner * Add group.features to test mocks * Wrap settings forms in FormContainer * Rename to KFormContainer and move to base * Add confirm step to accept/archive offer buttons * Use photo icon for offer image placeholder * Add offer as a "fake" empty result * Filter offers by status and sort by createdAt desc ... entries can get added via websockets that might not fit the filter, and might need reordering * Refine group offer cards - use QImg instead of lots of CSS - use QItem inside for nicer layout * Correct RouterLink casing * Update test snapshots * Please the pedantic linter * Remove offer description helper * Extract mapErrors to statusMixin * Add accept/archive text into i18n * Remove unneeded code * Add offer filter status text to i18n * Correct size for new offer button * Remove one layer of div soup * Put the group offer cards in proper links * Remove commented out code * Convert offer in websocket update * Prefix functional getter with get For getNotificationTypeStatus * Preserve route query when clicking on offer conv * Use icon service for latest messages offer item * Move withoutKeys to utils * Use invisible class instead of custom css * Don't put const value in data * Save disk space by compacting template * Remove unneeded v-model Was only used when I tried out quasar :rules * Document MultiCroppa value prop a bit more * Document the data that latestMesages/related has
* Use address autocomplete As it used to be. Also defaults place edit map to be group centre if available. * Remove uneeded extra wrapped div * Update setup for storyshots testing "sync: false" seems to be the new way it goes and will be the default in the future, see vuejs/vue-test-utils#1137 The transition group stubs seem to be there by default now too, I think.. Anyway it works where it did no tbefore :) Also see vuejs/vue-test-utils#1163 * Add @types/jest - for editor support See https://blog.jetbrains.com/webstorm/2018/10/testing-with-jest-in-webstorm/ * Increase test wait Not really sure why this changed, but don't want to think about it for now... * Add text to translation file * Use the spelling of the enemy * Simplify template logic
* Initial work to add person-to-person sharing * A few sharing item UI refinements * Initial new sharing form with multiple upload * Add a grey box... * Remove redundant check * Rename sharing to offers * Add a mock chat to offer detail UI * Create mobile version of offer detail UI * Tidy up multiple image editing * A bit more polish on the offer UI Some translations, icon, breadcrumb, etc... * Snapshot update * Add create offer breadcrumb title * Rename a few offer related things for consistency * Offer image carousel, multi upload, various bits * Refine image upload/remove/re-position * Add websocket listeners for offer changes * Wireup offer conversation * Basic features to allow to accept/archive offers * Remove uneeded demo data * Move selected offer data/logic to own store module * Preserve offer filter in more places The create/save filter preservation does not work actually as we clear the store contents on route change. * Remove status from offer form Status change is now done via explicit actions/buttons * Use address autocomplete (#1878) * Use address autocomplete As it used to be. Also defaults place edit map to be group centre if available. * Remove uneeded extra wrapped div * Update setup for storyshots testing "sync: false" seems to be the new way it goes and will be the default in the future, see vuejs/vue-test-utils#1137 The transition group stubs seem to be there by default now too, I think.. Anyway it works where it did no tbefore :) Also see vuejs/vue-test-utils#1163 * Add @types/jest - for editor support See https://blog.jetbrains.com/webstorm/2018/10/testing-with-jest-in-webstorm/ * Increase test wait Not really sure why this changed, but don't want to think about it for now... * Add text to translation file * Use the spelling of the enemy * Simplify template logic * Ffix multicroppa * Further refine offer editing, esp MultiCroppa * Use gift as offers menu item * Remove offer upload progress logging * Nicer create offer button * Clear offerDetail on route leave * Add offer list loading indicator * Add offer body loading indicator * Add loading spinner when fetching offer for edit * Correctly wire up offer form reset events * Only show offer accept/archive buttons if active * Handle updating offers after save/websocket better * Cleaner mobile form view * Only show carousel if >1 image * Fix offer header when name is very long * Fix offer detail image display when only 1 * Fix overflowing text on group offers page * White background offer description * Snapshot update * Don't try and be fancy with updating users * Fix style style * Hide offers if group does not have the feature * Check route features in after route hook * Actually filter offers by current group * Add offers covert function to convert createdAt * Display offer information in latest messages I did it a slightly different way, by adding related offers into the latestMessages state... * Keep related offers up to date via websocket It's a bit overkeen actually as most users won't be in the conversations for the offers, so we don't need to update the related item... should really check we need it first * Import default offer status from store * Use current route query instead of getter * Use + for new offer button * Allow setting new_offer notification types * Show offer status if not active Although it's a bit ugly * Change notification type spinner * Add group.features to test mocks * Wrap settings forms in FormContainer * Rename to KFormContainer and move to base * Add confirm step to accept/archive offer buttons * Use photo icon for offer image placeholder * Add offer as a "fake" empty result * Filter offers by status and sort by createdAt desc ... entries can get added via websockets that might not fit the filter, and might need reordering * Refine group offer cards - use QImg instead of lots of CSS - use QItem inside for nicer layout * Correct RouterLink casing * Update test snapshots * Please the pedantic linter * Remove offer description helper * Extract mapErrors to statusMixin * Add accept/archive text into i18n * Remove unneeded code * Add offer filter status text to i18n * Correct size for new offer button * Remove one layer of div soup * Put the group offer cards in proper links * Remove commented out code * Convert offer in websocket update * Prefix functional getter with get For getNotificationTypeStatus * Preserve route query when clicking on offer conv * Use icon service for latest messages offer item * Move withoutKeys to utils * Use invisible class instead of custom css * Don't put const value in data * Save disk space by compacting template * Remove unneeded v-model Was only used when I tried out quasar :rules * Document MultiCroppa value prop a bit more * Document the data that latestMesages/related has
What does this PR do?
Use autocomplete for address picker again as it used to. I made it so it gives you an explicit option to use the search term as the address without adding/changing any existing map marker.
Also defaults place edit map to be group centre if available.
I didn't add everything into translation strings, just as maybe there are some language changes in review (plus, I'm tired and about to go to bed ;) )
Links to related issues
Checklist