(revert) non-dutiable flag on rating request for shipments within EU.…

… only apply exclusion during shipment creation
karrioapi · Nov 24, 2023 · 628dc32 · 628dc32
1 parent 34dcd62
commit 628dc32
Show file tree

Hide file tree

Showing 2 changed files with 11 additions and 9 deletions.
diff --git a/sdk/extensions/dhl_express/karrio/providers/dhl_express/rate.py b/sdk/extensions/dhl_express/karrio/providers/dhl_express/rate.py
@@ -102,14 +102,7 @@ def rate_request(
         raise errors.DestinationNotServicedError(payload.shipper.country_code)
 
     is_document = all([parcel.is_document for parcel in payload.parcels])
-    is_dutiable = (
-        is_international and
-        not is_document and
-        (
-            units.EUCountry.map(payload.shipper.country_code).value is None and
-            units.EUCountry.map(payload.recipient.country_code).value is None
-        )
-    )
+    is_dutiable = is_international and not is_document
 
     services = lib.to_services(
         payload.services,

diff --git a/sdk/extensions/dhl_express/tests/dhl_express/test_rate.py b/sdk/extensions/dhl_express/tests/dhl_express/test_rate.py
@@ -391,13 +391,22 @@ def test_parse_rate_vol_weight_higher_response(self):
                 </Piece>
             </Pieces>
             <PaymentAccountNumber>123456789</PaymentAccountNumber>
-            <IsDutiable>N</IsDutiable>
+            <IsDutiable>Y</IsDutiable>
             <NetworkTypeCode>AL</NetworkTypeCode>
+            <QtdShp>
+                <QtdShpExChrg>
+                    <SpecialServiceType>WY</SpecialServiceType>
+                </QtdShpExChrg>
+            </QtdShp>
         </BkgDetails>
         <To>
             <CountryCode>NL</CountryCode>
             <Postalcode>76131</Postalcode>
         </To>
+        <Dutiable>
+            <DeclaredCurrency>EUR</DeclaredCurrency>
+            <DeclaredValue>1.</DeclaredValue>
+        </Dutiable>
     </GetQuote>
 </p:DCTRequest>
 """