This repository has been archived by the owner on Dec 14, 2020. It is now read-only.
Change default coding style to PSR-12 #9
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
jaylinski
commented
Nov 12, 2019
jaylinski
commented
- Dropped support for phpspec v4
- Updated deps
jaylinski
commented
Nov 12, 2019
jaylinski
commented
Nov 12, 2019
| @@ -16,7 +16,7 @@ class CodeStyleFixer implements ComposerScriptInterface | |||
| * | |||
| * @var string | |||
| */ | |||
| private static $command = 'php-cs-fixer fix src --rules=@PSR2 --using-cache=false'; | |||
| private static $command = 'phpcbf src --standard=PSR12'; | |||
There was a problem hiding this comment.
php-cs-fixer doesn't support PSR-12 yet: PHP-CS-Fixer/PHP-CS-Fixer#4502
jaylinski
commented
Nov 13, 2019
added 2 commits
November 18, 2019 11:58
Resolves #7
* Dropped support for phpspec v4 * Updated deps
|
I tried to change the See also https://twitter.com/GrahamJCampbell/status/1161012976499011585. |
Witti
approved these changes
Nov 18, 2019
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.