forked from vuejs/vue-element
-
Notifications
You must be signed in to change notification settings - Fork 186
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Allow template syntax for slots #121
Merged
karol-f
merged 8 commits into
karol-f:master
from
dennisbaskin:allow-template-syntax-for-slots
May 27, 2018
Merged
Allow template syntax for slots #121
karol-f
merged 8 commits into
karol-f:master
from
dennisbaskin:allow-template-syntax-for-slots
May 27, 2018
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
In some environments childNodes only exist on the content property, and if that fails, then we provide a fallback to check the innerHTML
Referencing issue: #118 |
Thanks, will look at it soon! |
karol-f
added a commit
that referenced
this pull request
May 27, 2018
…lots Allow template syntax for slots
karol-f
added a commit
that referenced
this pull request
May 27, 2018
Released in @3.1.0 (https://github.com/karol-f/vue-custom-element/releases/tag/v3.1.0). Thanks for the PR! |
Thank you! 😸 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds the following functionality (notes taken from docs):
Using Template Tags
To use template tags to add content without necessitating the need for an element wrapper, you can follow the following pattern:
You would need to add the
slot
attribute (not avue-slot
) and provide anid
attribute that matches the name of the slot you wish to add content to.Passing Custom Elements Inside Slots
When passing custom elements inside of slots, you may get errors that warn about
Unknown custom element
. There are two ways around this.Add your custom element to a list of ignored elements in the vue config:
Make sure the elments being inserted into another element are created as custom elements first: