Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

update reference doc for cli and components #747

Merged
merged 1 commit into from
Nov 30, 2024

Conversation

chaosi-zju
Copy link
Member

@chaosi-zju chaosi-zju commented Nov 30, 2024

What type of PR is this?

/kind documentation

What this PR does / why we need it:

update reference doc for cli and components

Which issue(s) this PR fixes:

Fixes #

Special notes for your reviewer:

Signed-off-by: chaosi-zju <chaosi@zju.edu.cn>
@karmada-bot karmada-bot added the kind/documentation Categorizes issue or PR as related to documentation. label Nov 30, 2024
@karmada-bot karmada-bot added the size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. label Nov 30, 2024
@chaosi-zju chaosi-zju changed the title Api archive release-1.12 version doc Nov 30, 2024
@chaosi-zju
Copy link
Member Author

/cc @RainbowMango @zhzhuang-zju

@RainbowMango
Copy link
Member

/hold
wait for #728

@karmada-bot karmada-bot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Nov 30, 2024
@RainbowMango
Copy link
Member

Why not update the reference doc with a separate PR?

@karmada-bot karmada-bot added size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. and removed size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. labels Nov 30, 2024
@chaosi-zju chaosi-zju changed the title archive release-1.12 version doc update release-1.12 reference doc for cli and components Nov 30, 2024
@chaosi-zju
Copy link
Member Author

Why not update the reference doc with a separate PR?

done

@chaosi-zju
Copy link
Member Author

/unhold

@karmada-bot karmada-bot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Nov 30, 2024
@chaosi-zju chaosi-zju changed the title update release-1.12 reference doc for cli and components update reference doc for cli and components Nov 30, 2024
Copy link
Member

@RainbowMango RainbowMango left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm
/approve

Note that we might need to wait for #748 before archiving the release docs.

@karmada-bot karmada-bot added the lgtm Indicates that a PR is ready to be merged. label Nov 30, 2024
@karmada-bot
Copy link
Collaborator

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: RainbowMango

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@karmada-bot karmada-bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Nov 30, 2024
@karmada-bot karmada-bot merged commit 90d715f into karmada-io:main Nov 30, 2024
7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. kind/documentation Categorizes issue or PR as related to documentation. lgtm Indicates that a PR is ready to be merged. size/XL Denotes a PR that changes 500-999 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants