Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[zh] Sync core-concepts/components.md #745

Merged
merged 1 commit into from
Nov 30, 2024
Merged

Conversation

diebbCN
Copy link
Contributor

@diebbCN diebbCN commented Nov 29, 2024

What type of PR is this?
/kind documentation

What this PR does / why we need it:
Sync with the english text

Which issue(s) this PR fixes:
Fixes #

Special notes for your reviewer:

@karmada-bot karmada-bot added the kind/documentation Categorizes issue or PR as related to documentation. label Nov 29, 2024
@karmada-bot
Copy link
Collaborator

Welcome @diebbCN! It looks like this is your first PR to karmada-io/website 🎉

@karmada-bot karmada-bot added the size/S Denotes a PR that changes 10-29 lines, ignoring generated files. label Nov 29, 2024
Copy link
Member

@windsonsea windsonsea left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

These changes are to keep consistent with english version. You need to sign off by running:

git commit -s --amend
git push -f

@karmada-bot karmada-bot added the lgtm Indicates that a PR is ready to be merged. label Nov 29, 2024
@diebbCN
Copy link
Contributor Author

diebbCN commented Nov 29, 2024

/lgtm

These changes are to keep consistent with english version. You need to sign off by running:

git commit -s --amend
git push -f

@windsonsea I got it.

@diebbCN
Copy link
Contributor Author

diebbCN commented Nov 29, 2024

/lgtm

These changes are to keep consistent with english version. You need to sign off by running:

git commit -s --amend
git push -f

Sorry, I'm new to Git. What should I do next? Should I resubmit a PR? @windsonsea

@windsonsea
Copy link
Member

  1. Run this command on your patch-1 branch locally:

    git commit -s --amend
    
  2. Need not change nothing. Press the ESC key, and type :wq

  3. Run the command to push again:

    git push origin patch-1 -f
    

Signed-off-by: diebbCN <66955249@qq.com>
@karmada-bot karmada-bot removed the lgtm Indicates that a PR is ready to be merged. label Nov 29, 2024
@diebbCN
Copy link
Contributor Author

diebbCN commented Nov 29, 2024

  1. Run this command on your patch-1 branch locally:
    git commit -s --amend
    
  2. Need not change nothing. Press the ESC key, and type :wq
  3. Run the command to push again:
    git push origin patch-1 -f
    

Thank you, I understand how to do it now :) @windsonsea

Copy link
Member

@windsonsea windsonsea left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@karmada-bot karmada-bot added the lgtm Indicates that a PR is ready to be merged. label Nov 29, 2024
Copy link
Member

@RainbowMango RainbowMango left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/approve
Thanks.

@karmada-bot
Copy link
Collaborator

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: RainbowMango

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@karmada-bot karmada-bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Nov 30, 2024
@karmada-bot karmada-bot merged commit fbe3382 into karmada-io:main Nov 30, 2024
7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. kind/documentation Categorizes issue or PR as related to documentation. lgtm Indicates that a PR is ready to be merged. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants