Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add tutorial doc in website repo about how to do migration rollback #698

Merged
merged 1 commit into from
Oct 29, 2024

Conversation

wulemao
Copy link
Contributor

@wulemao wulemao commented Sep 30, 2024

What type of PR is this?

/kind documentation

What this PR does / why we need it:

add tutorial doc in website repo about how to do migration rollback

Which issue(s) this PR fixes:

Fixes part of karmada-io/karmada#5380

Special notes for your reviewer:

@karmada-bot karmada-bot added the kind/documentation Categorizes issue or PR as related to documentation. label Sep 30, 2024
@karmada-bot karmada-bot added the size/S Denotes a PR that changes 10-29 lines, ignoring generated files. label Sep 30, 2024
@wulemao wulemao changed the title add tutorial doc in website repo about how to do migration rollback [WIP] add tutorial doc in website repo about how to do migration rollback Sep 30, 2024
@karmada-bot karmada-bot added the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Sep 30, 2024
@samzong
Copy link
Member

samzong commented Oct 15, 2024

If in WIP, maybe you can change the PR status to Draft.

@karmada-bot karmada-bot added size/L Denotes a PR that changes 100-499 lines, ignoring generated files. and removed size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Oct 26, 2024
@wulemao wulemao force-pushed the turial branch 3 times, most recently from 058963b to 5036fef Compare October 28, 2024 03:31
@wulemao wulemao changed the title [WIP] add tutorial doc in website repo about how to do migration rollback add tutorial doc in website repo about how to do migration rollback Oct 28, 2024
@karmada-bot karmada-bot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Oct 28, 2024
@chaosi-zju
Copy link
Member

chaosi-zju commented Oct 28, 2024

/lgtm

/cc @samzong @RainbowMango quick preview

Copy link
Member

@RainbowMango RainbowMango left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This review only focuses on the new content.

docs/tutorials/resource-migration.md Outdated Show resolved Hide resolved
docs/tutorials/resource-migration.md Outdated Show resolved Hide resolved
docs/tutorials/resource-migration.md Outdated Show resolved Hide resolved
docs/tutorials/resource-migration.md Outdated Show resolved Hide resolved
docs/tutorials/resource-migration.md Outdated Show resolved Hide resolved
@karmada-bot karmada-bot removed the lgtm Indicates that a PR is ready to be merged. label Oct 28, 2024
@wulemao
Copy link
Contributor Author

wulemao commented Oct 28, 2024

all comments fixed

Copy link
Member

@RainbowMango RainbowMango left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm
/approve

@karmada-bot karmada-bot added the lgtm Indicates that a PR is ready to be merged. label Oct 29, 2024
@karmada-bot
Copy link
Collaborator

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: RainbowMango

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@karmada-bot karmada-bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Oct 29, 2024
@karmada-bot karmada-bot merged commit 9e2383c into karmada-io:main Oct 29, 2024
7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. kind/documentation Categorizes issue or PR as related to documentation. lgtm Indicates that a PR is ready to be merged. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants