Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add kubeconfig in unified auth #441

Merged
merged 2 commits into from
Aug 7, 2023

Conversation

Affan-7
Copy link
Contributor

@Affan-7 Affan-7 commented Aug 5, 2023

What type of PR is this?
/kind documentation

What this PR does / why we need it:
This PR specifies which kubeconfig file to use in the step3 of the unified authentication to avoid any user confusion.

Which issue(s) this PR fixes:
Fixes #437

@karmada-bot karmada-bot added the kind/documentation Categorizes issue or PR as related to documentation. label Aug 5, 2023
@karmada-bot karmada-bot added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label Aug 5, 2023
Signed-off-by: Mohammed Affan <mohammed.affan.727@gmail.com>
Signed-off-by: Mohammed Affan <mohammed.affan.727@gmail.com>
Copy link
Member

@Arhell Arhell left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@karmada-bot karmada-bot added the lgtm Indicates that a PR is ready to be merged. label Aug 5, 2023
@Arhell Arhell removed their assignment Aug 5, 2023
Copy link
Member

@XiShanYongYe-Chang XiShanYongYe-Chang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks a lot
/lgtm

Copy link
Member

@RainbowMango RainbowMango left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/approve

@karmada-bot
Copy link
Collaborator

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: RainbowMango

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@karmada-bot karmada-bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Aug 7, 2023
@karmada-bot karmada-bot merged commit b6275db into karmada-io:main Aug 7, 2023
5 checks passed
@Affan-7 Affan-7 deleted the unified-auth-kubeconfig branch August 7, 2023 06:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. kind/documentation Categorizes issue or PR as related to documentation. lgtm Indicates that a PR is ready to be merged. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[HELP] Optimize unified-auth Document
5 participants