Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix the attached binding deletion problem #6034

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

whitewindmills
Copy link
Member

What type of PR is this?
/kind bug

What this PR does / why we need it:

I created a deployment that used a PVC as it's dependent resource, and the PVC was able to follow the deployment propagation correctly. When I deleted the PVC and recreated it, I found that the PVC did not follow the deployment propagation because it's ResourceBinding was not created.

dependency_pr

Which issue(s) this PR fixes:
none

Special notes for your reviewer:

Does this PR introduce a user-facing change?:

NONE

Signed-off-by: whitewindmills <jayfantasyhjh@gmail.com>
@karmada-bot karmada-bot added the kind/bug Categorizes issue or PR as related to a bug. label Jan 10, 2025
@karmada-bot
Copy link
Collaborator

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
Once this PR has been reviewed and has the lgtm label, please assign rainbowmango for approval. For more information see the Kubernetes Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@karmada-bot karmada-bot added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label Jan 10, 2025
@whitewindmills
Copy link
Member Author

/cc @XiShanYongYe-Chang

@codecov-commenter
Copy link

⚠️ Please install the 'codecov app svg image' to ensure uploads and comments are reliably processed by Codecov.

Codecov Report

Attention: Patch coverage is 50.00000% with 3 lines in your changes missing coverage. Please review.

Project coverage is 48.36%. Comparing base (be674c7) to head (6acb412).
Report is 2 commits behind head on master.

Files with missing lines Patch % Lines
...ependenciesdistributor/dependencies_distributor.go 50.00% 2 Missing and 1 partial ⚠️

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #6034      +/-   ##
==========================================
- Coverage   48.37%   48.36%   -0.01%     
==========================================
  Files         665      666       +1     
  Lines       54831    54835       +4     
==========================================
- Hits        26524    26523       -1     
- Misses      26590    26594       +4     
- Partials     1717     1718       +1     
Flag Coverage Δ
unittests 48.36% <50.00%> (-0.01%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@XiShanYongYe-Chang
Copy link
Member

Thanks, @whitewindmills let me take a look.
/assign

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind/bug Categorizes issue or PR as related to a bug. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants