-
Notifications
You must be signed in to change notification settings - Fork 894
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
auto create pr to update helm index when release chart #5911
base: master
Are you sure you want to change the base?
Conversation
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
hi @a7i , can you give some advices on this PR, thank you very much~ |
faf068f
to
607b6c0
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅
❗ Your organization needs to install the Codecov GitHub app to enable full functionality. Additional details and impacted files@@ Coverage Diff @@
## master #5911 +/- ##
==========================================
+ Coverage 47.86% 47.95% +0.08%
==========================================
Files 663 663
Lines 54761 54769 +8
==========================================
+ Hits 26210 26262 +52
+ Misses 26845 26801 -44
Partials 1706 1706
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
/lgtm 🏆 |
Signed-off-by: chaosi-zju <chaosi@zju.edu.cn>
@RainbowMango So, you prefer how we move this forward, is add |
What type of PR is this?
/kind feature
What this PR does / why we need it:
Auto create pr to update helm index when release chart.
You can see the effective demonstration in my personal repo:
Which issue(s) this PR fixes:
Fixes #
Special notes for your reviewer:
I investigated the helm/chart-releaser-action. It generates Helm chart releases and updates the chart index on the
gh-pages
branch, but this is not what we need:chart-releaser-action
still need someone to submit a pr to updatecharts/karmada/Chart.yaml
, in order to trigger the process of this action. However, I think it would be better if the operation of update index can be just right triggered by publishing release without anyone manually submit any pr.chart-releaser-action
requires a additional branchgh-pages
.So, we just only need a CI process that automatically updates the chart index when a new release is published.
Does this PR introduce a user-facing change?: