Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(cluster): remove raleted metrics label when cluster is deleted #5866

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

CharlesQQ
Copy link
Contributor

What type of PR is this?
/kind bug

What this PR does / why we need it:

Which issue(s) this PR fixes:
Fixes #5843

Special notes for your reviewer:

Does this PR introduce a user-facing change?:


@karmada-bot karmada-bot added the kind/bug Categorizes issue or PR as related to a bug. label Nov 23, 2024
@karmada-bot
Copy link
Collaborator

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
Once this PR has been reviewed and has the lgtm label, please assign garrybest for approval. For more information see the Kubernetes Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@karmada-bot karmada-bot added the size/S Denotes a PR that changes 10-29 lines, ignoring generated files. label Nov 23, 2024
@codecov-commenter
Copy link

codecov-commenter commented Nov 23, 2024

⚠️ Please install the 'codecov app svg image' to ensure uploads and comments are reliably processed by Codecov.

Codecov Report

Attention: Patch coverage is 12.50000% with 14 lines in your changes missing coverage. Please review.

Project coverage is 46.28%. Comparing base (88c3e44) to head (bd68ef8).
Report is 38 commits behind head on master.

Files with missing lines Patch % Lines
pkg/metrics/cluster.go 0.00% 11 Missing ⚠️
pkg/controllers/cluster/cluster_controller.go 40.00% 2 Missing and 1 partial ⚠️

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #5866      +/-   ##
==========================================
+ Coverage   46.20%   46.28%   +0.07%     
==========================================
  Files         663      663              
  Lines       54580    54777     +197     
==========================================
+ Hits        25218    25352     +134     
- Misses      27739    27796      +57     
- Partials     1623     1629       +6     
Flag Coverage Δ
unittests 46.28% <12.50%> (+0.07%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Member

@RainbowMango RainbowMango left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Have you tested it? Can you share the metrics before and after cluster is deleted?

Comment on lines 244 to 248
defer func() {
metrics.RemoveClusterStatus(cluster)
}()
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What if the removeCluster raises an error? Do we still clean up the metrics?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What if the removeCluster raises an error? Do we still clean up the metrics?

shouldn't clean up the metrics, I'll fix it!

Copy link
Contributor Author

@CharlesQQ CharlesQQ Nov 29, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Have you tested it? Can you share the metrics before and after cluster is deleted?

yes, I join a cluster named host

Before metrics: following metrics not removed after host deleted from karmada

cluster_ready_node_number{cluster_name="host"} 0
cluster_ready_state{cluster_name="host"} 1
cluster_sync_status_duration_seconds_bucket{cluster_name="host",le="0.005"} 0
cluster_sync_status_duration_seconds_bucket{cluster_name="host",le="0.01"} 0
cluster_sync_status_duration_seconds_bucket{cluster_name="host",le="0.025"} 0
cluster_sync_status_duration_seconds_bucket{cluster_name="host",le="0.05"} 1
cluster_sync_status_duration_seconds_bucket{cluster_name="host",le="0.1"} 3
cluster_sync_status_duration_seconds_bucket{cluster_name="host",le="0.25"} 3
cluster_sync_status_duration_seconds_bucket{cluster_name="host",le="0.5"} 4
cluster_sync_status_duration_seconds_bucket{cluster_name="host",le="1"} 4
cluster_sync_status_duration_seconds_bucket{cluster_name="host",le="2.5"} 4
cluster_sync_status_duration_seconds_bucket{cluster_name="host",le="5"} 4
cluster_sync_status_duration_seconds_bucket{cluster_name="host",le="10"} 4
cluster_sync_status_duration_seconds_bucket{cluster_name="host",le="+Inf"} 4
cluster_sync_status_duration_seconds_sum{cluster_name="host"} 0.667916613
cluster_sync_status_duration_seconds_count{cluster_name="host"} 4

After: metrics removed successfully.

Signed-off-by: chang.qiangqiang <chang.qiangqiang@immomo.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind/bug Categorizes issue or PR as related to a bug. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

After deleting the cluster, also need to delete related metrics label.
4 participants