Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(worker): add metrics for asyncworker #5817

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

CharlesQQ
Copy link
Contributor

What type of PR is this?
/kind feature

What this PR does / why we need it:

Which issue(s) this PR fixes:
Fixes #5791

Special notes for your reviewer:

Does this PR introduce a user-facing change?:


@karmada-bot karmada-bot added the kind/feature Categorizes issue or PR as related to a new feature. label Nov 14, 2024
@karmada-bot
Copy link
Collaborator

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
Once this PR has been reviewed and has the lgtm label, please assign rainbowmango for approval. For more information see the Kubernetes Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@karmada-bot karmada-bot added the size/L Denotes a PR that changes 100-499 lines, ignoring generated files. label Nov 14, 2024
@codecov-commenter
Copy link

codecov-commenter commented Nov 14, 2024

⚠️ Please install the 'codecov app svg image' to ensure uploads and comments are reliably processed by Codecov.

Codecov Report

Attention: Patch coverage is 32.97872% with 63 lines in your changes missing coverage. Please review.

Project coverage is 44.83%. Comparing base (35b7e8f) to head (4892551).

Files with missing lines Patch % Lines
pkg/metrics/asyncworker.go 0.00% 26 Missing ⚠️
pkg/detector/detector.go 0.00% 9 Missing ⚠️
pkg/controllers/cluster/taint_manager.go 33.33% 4 Missing ⚠️
pkg/clusterdiscovery/clusterapi/clusterapi.go 0.00% 3 Missing ⚠️
pkg/controllers/mcs/service_export_controller.go 0.00% 3 Missing ⚠️
...clusterservice/endpointslice_collect_controller.go 0.00% 3 Missing ⚠️
...ependenciesdistributor/dependencies_distributor.go 25.00% 3 Missing ⚠️
pkg/util/worker/worker.go 75.00% 2 Missing and 1 partial ⚠️
...targetmarker/hpa_scale_target_marker_controller.go 0.00% 2 Missing ⚠️
cmd/agent/app/agent.go 0.00% 1 Missing ⚠️
... and 6 more

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #5817      +/-   ##
==========================================
- Coverage   44.84%   44.83%   -0.01%     
==========================================
  Files         658      659       +1     
  Lines       53917    53955      +38     
==========================================
+ Hits        24180    24192      +12     
- Misses      28169    28195      +26     
  Partials     1568     1568              
Flag Coverage Δ
unittests 44.83% <32.97%> (-0.01%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@CharlesQQ CharlesQQ force-pushed the asyncworker-metrics branch 13 times, most recently from cd5a52c to 2aabd24 Compare November 15, 2024 03:45
Signed-off-by: chang.qiangqiang <chang.qiangqiang@immomo.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind/feature Categorizes issue or PR as related to a new feature. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add prometheus counter metrics for asyncWorker , which like metrics of controller-runtime repository
3 participants