-
Notifications
You must be signed in to change notification settings - Fork 913
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Added tests for multiclusterservice controller #5589
Added tests for multiclusterservice controller #5589
Conversation
Signed-off-by: Anuj Agrawal <anujagrawal380@gmail.com>
Hi @mohamedawnallah, #5287 is failing. Can you please check. |
Thanks, @anujagrawal699, for the heads-up! @XiShanYongYe-Chang proactively submitted a PR for this (#5580) and it's currently under review. |
Ohkay, Thanks! |
/retest |
/assign |
Codecov ReportAll modified and coverable lines are covered by tests ✅
❗ Your organization needs to install the Codecov GitHub app to enable full functionality. Additional details and impacted files@@ Coverage Diff @@
## master #5589 +/- ##
==========================================
+ Coverage 34.10% 34.83% +0.72%
==========================================
Files 645 645
Lines 44857 44857
==========================================
+ Hits 15298 15624 +326
+ Misses 28400 28028 -372
- Partials 1159 1205 +46
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
/approve
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: XiShanYongYe-Chang The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Description:
This PR introduces comprehensive unit tests for the Multi-Cluster Services controllers. These tests aim to improve code reliability and facilitate easier maintenance and future development.
Additions:
Test Coverage:
Overall coverage of multiclusterservice controller : 0% to 35.8%
What type of PR is this?
/kind failing-test
/kind feature
Which issue(s) this PR fixes:
Fixes a part of #5470
Does this PR introduce a user-facing change?: