-
Notifications
You must be signed in to change notification settings - Fork 905
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: remove extra slash when constructing member cluster URL to adapt… #5556
Conversation
/approve |
Codecov ReportAttention: Patch coverage is
❗ Your organization needs to install the Codecov GitHub app to enable full functionality. Additional details and impacted files@@ Coverage Diff @@
## release-1.10 #5556 +/- ##
================================================
+ Coverage 53.29% 53.34% +0.04%
================================================
Files 253 253
Lines 20597 20597
================================================
+ Hits 10978 10988 +10
+ Misses 8890 8878 -12
- Partials 729 731 +2
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
@spiritNO1 thanks, can you help fix the lint? |
Kindly ping @spiritNO1 |
OK, I will fix it in a few days |
… the apiEndpoint of the cluster object ends with a slash. Signed-off-by: 圣朋 <sp441185@alibaba-inc.com>
c5f4d36
to
ad357bc
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
/approve
Thanks~
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: spiritNO1, XiShanYongYe-Chang The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
… the apiEndpoint of the cluster object ends with a slash.
What type of PR is this?
What this PR does / why we need it:
Which issue(s) this PR fixes:
Fixes #5455
Special notes for your reviewer:
Does this PR introduce a user-facing change?: