Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: remove extra slash when constructing member cluster URL to adapt… #5556

Merged
merged 1 commit into from
Oct 8, 2024

Conversation

spiritNO1
Copy link
Contributor

… the apiEndpoint of the cluster object ends with a slash.

What type of PR is this?

What this PR does / why we need it:

Which issue(s) this PR fixes:
Fixes #5455

Special notes for your reviewer:

Does this PR introduce a user-facing change?:

karmada-aggregated-apiserver: User can append a "/" at the end when configuring the cluster's apiEndpoint.

@karmada-bot karmada-bot added the size/M Denotes a PR that changes 30-99 lines, ignoring generated files. label Sep 16, 2024
@spiritNO1
Copy link
Contributor Author

/approve

@codecov-commenter
Copy link

codecov-commenter commented Sep 16, 2024

⚠️ Please install the 'codecov app svg image' to ensure uploads and comments are reliably processed by Codecov.

Codecov Report

Attention: Patch coverage is 66.66667% with 1 line in your changes missing coverage. Please review.

Project coverage is 53.34%. Comparing base (5c6c155) to head (ad357bc).

Files with missing lines Patch % Lines
pkg/registry/cluster/storage/aggregate.go 66.66% 1 Missing ⚠️

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files
@@               Coverage Diff                @@
##           release-1.10    #5556      +/-   ##
================================================
+ Coverage         53.29%   53.34%   +0.04%     
================================================
  Files               253      253              
  Lines             20597    20597              
================================================
+ Hits              10978    10988      +10     
+ Misses             8890     8878      -12     
- Partials            729      731       +2     
Flag Coverage Δ
unittests 53.34% <66.66%> (+0.04%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@XiShanYongYe-Chang
Copy link
Member

@spiritNO1 thanks, can you help fix the lint?

@XiShanYongYe-Chang
Copy link
Member

Kindly ping @spiritNO1

@spiritNO1
Copy link
Contributor Author

Kindly ping @spiritNO1

OK, I will fix it in a few days

… the apiEndpoint of the cluster object ends with a slash.

Signed-off-by: 圣朋 <sp441185@alibaba-inc.com>
Copy link
Member

@XiShanYongYe-Chang XiShanYongYe-Chang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm
/approve
Thanks~

@karmada-bot karmada-bot added the lgtm Indicates that a PR is ready to be merged. label Oct 8, 2024
@karmada-bot
Copy link
Collaborator

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: spiritNO1, XiShanYongYe-Chang

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@karmada-bot karmada-bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Oct 8, 2024
@karmada-bot karmada-bot merged commit bc48a4f into karmada-io:release-1.10 Oct 8, 2024
12 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants