pkg/webhook: unit test resource binding #5497
Conversation
karmada-bot
added
the
kind/failing-test
karmada-bot
added
kind/feature
|
Codecov ReportAll modified and coverable lines are covered by tests ✅
❗ Your organization needs to install the Codecov GitHub app to enable full functionality. Additional details and impacted files@@ Coverage Diff @@
## master #5497 +/- ##
==========================================
+ Coverage 31.70% 34.06% +2.36%
==========================================
Files 643 643
Lines 44445 44509 +64
==========================================
+ Hits 14090 15164 +1074
+ Misses 29325 28192 -1133
- Partials 1030 1153 +123
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
|
Closing and reopening some flaky e2e failures... |
In this commit, we introduce unit tests for the `MutatingAdmission` webhook that mutates the `ResourceBinding` resource. These tests ensure correct behavior for various mutation scenarios and improve coverage: - Testing the handling of decode errors and ensuring that admission is denied when decoding fails. - Full coverage testing of policy mutation, including setting default UUID labels for the `ResourceBinding`. - Verifying that only the expected patch for the UUID label is applied, ensuring no other unnecessary mutations. Signed-off-by: Mohamed Awnallah <mohamedmohey2352@gmail.com>
mohamedawnallah
force-pushed
the
unitTestResourceBindingWebhook
branch
from
b6e5efb to
e689eaf
Compare
|
/retest |
|
@mohamedawnallah: Cannot trigger testing until a trusted user reviews the PR and leaves an In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
|
/ok-to-test |
|
@mohamedawnallah: Cannot trigger testing until a trusted user reviews the PR and leaves an In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
|
Closing and reopening some flaky e2e failures... |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: XiShanYongYe-Chang The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
karmada-bot
added
the
approved
Description
In this commit, we introduce unit tests for the
MutatingAdmissionwebhook that mutates theResourceBindingresource. These tests ensure correct behavior for various mutation scenarios and improve coverage:ResourceBinding.What type of PR is this?
/kind failing-test
/kind feature
Which issue(s) this PR fixes:
Part of #5491
Does this PR introduce a user-facing change?: