fix: fixed the pinned dependencies issue #5396
Conversation
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
karmada-bot
added
the
size/L
|
Codecov ReportAll modified and coverable lines are covered by tests ✅
❗ Your organization needs to install the Codecov GitHub app to enable full functionality. Additional details and impacted files@@ Coverage Diff @@
## master #5396 +/- ##
=======================================
Coverage 31.14% 31.14%
=======================================
Files 640 640
Lines 44417 44417
=======================================
+ Hits 13832 13834 +2
+ Misses 29583 29582 -1
+ Partials 1002 1001 -1
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
Signed-off-by: harshitasao <harshitasao@gmail.com>
harshitasao
force-pushed
the
pinned-dependencies-fix
branch
from
cc01378 to
4c405fa
Compare
| @@ -59,6 +62,9 @@ jobs: | |||
| - name: upload logs | |||
| if: always() | |||
| uses: actions/upload-artifact@v4 | |||
| - uses: chainguard-dev/actions/kind-diag@2faf313e789d339d91d3c4a73445ccdf90e5272d # main | |||
| # Only upload logs on failure. | |||
| if: ${{ failure() }} | |||
| with: | |||
There was a problem hiding this comment.
Looks like a wrong update was done here.
| - uses: helm/kind-action@0025e74a8c7512023d06dc019c617aa3cf561fde # v1.10.0 | ||
| with: | ||
| version: "v0.22.0" |
There was a problem hiding this comment.
Looks like a wrong update was done here.
There was a problem hiding this comment.
just need to update the version of action and not add a new action step.
| @@ -7,7 +7,7 @@ on: | |||
| - 'dependabot/**' | |||
|
|
|||
| permissions: | |||
| contents: read # Required by actions/checkout@v4 to fetch the repository contents. | |||
| contents: read # Required by actions/checkout@692973e3d937129bcbf40652eb9f2f61becf3332 # v4.1.7 to fetch the repository contents. | |||
There was a problem hiding this comment.
| contents: read # Required by actions/checkout@692973e3d937129bcbf40652eb9f2f61becf3332 # v4.1.7 to fetch the repository contents. | |
| contents: read # Required by actions/checkout to fetch the repository contents. |
We can remove the version information from the comments to reduce maintenance costs.
What this PR does / why we need it:
fixed the pinned dependencies issue reported by scorecard.
Which issue(s) this PR fixes:
Part of #5391
Special notes for your reviewer:
NONE
Does this PR introduce a user-facing change?: