-
Notifications
You must be signed in to change notification settings - Fork 905
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Bump golang version to 1.21.13 to address security warnings #5371
Conversation
Signed-off-by: zhzhuang-zju <m17799853869@163.com>
Codecov ReportAll modified and coverable lines are covered by tests ✅
❗ Your organization needs to install the Codecov GitHub app to enable full functionality. Additional details and impacted files@@ Coverage Diff @@
## release-1.10 #5371 +/- ##
================================================
- Coverage 53.31% 53.30% -0.01%
================================================
Files 253 253
Lines 20576 20576
================================================
- Hits 10970 10968 -2
- Misses 8880 8881 +1
- Partials 726 727 +1
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
/retest STEP: Check if deployment(karmadatest-mv6zx/deploy-qs7nz) disappears on member clusters @ 08/14/24 10:29:40.34
<< Timeline
[FAILED] Timed out after 420.001s.
Expected
<bool>: false
to equal
<bool>: true
In [It] at: /home/runner/work/karmada/karmada/test/e2e/framework/deployment.go:82 @ 08/14/24 10:29:40.325
Full Stack Trace
github.com/karmada-io/karmada/test/e2e/framework.WaitDeploymentPresentOnClusterFitWith({0xc00053a3a9, 0x7}, {0xc00011fa40, 0x11}, {0xc000d10cc4, 0xc}, 0xc0004a8ab0)
/home/runner/work/karmada/karmada/test/e2e/framework/deployment.go:82 +0x614
github.com/karmada-io/karmada/test/e2e/framework.WaitDeploymentPresentOnClustersFitWith.func1()
/home/runner/work/karmada/karmada/test/e2e/framework/deployment.go:100 +0xc5
github.com/karmada-io/karmada/test/e2e/framework.WaitDeploymentPresentOnClustersFitWith({0xc0009f8200, 0x3, 0x4}, {0xc00011fa40, 0x11}, {0xc000d10cc4, 0xc}, 0xc0004a8ab0)
/home/runner/work/karmada/karmada/test/e2e/framework/deployment.go:98 +0x236
github.com/karmada-io/karmada/test/e2e.glob..func33.1.3.3()
/home/runner/work/karmada/karmada/test/e2e/propagationpolicy_test.go:598 +0x35b
github.com/karmada-io/karmada/test/e2e.glob..func33.1.3()
/home/runner/work/karmada/karmada/test/e2e/propagationpolicy_test.go:596 +0x2c7 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
/approve
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: RainbowMango The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
What type of PR is this?
/kind cleanup
What this PR does / why we need it:
Bump golang version to 1.21.13 to address security warnings
Which issue(s) this PR fixes:
Fixes #
Special notes for your reviewer:
Does this PR introduce a user-facing change?: