Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump golang version to 1.21.13 to address security warnings #5371

Merged
merged 1 commit into from
Aug 15, 2024

Conversation

zhzhuang-zju
Copy link
Contributor

What type of PR is this?
/kind cleanup

What this PR does / why we need it:
Bump golang version to 1.21.13 to address security warnings

Which issue(s) this PR fixes:
Fixes #

Special notes for your reviewer:

✗ hack/scan-image-vuln.sh -i docker.io/karmada/karmada-controller-manager:v1.10
Preparing: 'trivy' existence check - pass
---------------------------- the image scanning result of Image <<docker.io/karmada/karmada-controller-manager:v1.10>> ----------------------------

docker.io/karmada/karmada-controller-manager:v1.10 (alpine 3.20.2)

Total: 0 (UNKNOWN: 0, LOW: 0, MEDIUM: 0, HIGH: 0, CRITICAL: 0)

Does this PR introduce a user-facing change?:

Bump golang version to `v1.21.13`

Signed-off-by: zhzhuang-zju <m17799853869@163.com>
@karmada-bot karmada-bot added the kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. label Aug 14, 2024
@karmada-bot karmada-bot added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label Aug 14, 2024
@codecov-commenter
Copy link

⚠️ Please install the 'codecov app svg image' to ensure uploads and comments are reliably processed by Codecov.

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 53.30%. Comparing base (1c5d8dc) to head (fdb28df).

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files
@@               Coverage Diff                @@
##           release-1.10    #5371      +/-   ##
================================================
- Coverage         53.31%   53.30%   -0.01%     
================================================
  Files               253      253              
  Lines             20576    20576              
================================================
- Hits              10970    10968       -2     
- Misses             8880     8881       +1     
- Partials            726      727       +1     
Flag Coverage Δ
unittests 53.30% <ø> (-0.01%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@liangyuanpeng
Copy link
Contributor

/retest

  STEP: Check if deployment(karmadatest-mv6zx/deploy-qs7nz) disappears on member clusters @ 08/14/24 10:29:40.34
  << Timeline

  [FAILED] Timed out after 420.001s.
  Expected
      <bool>: false
  to equal
      <bool>: true
  In [It] at: /home/runner/work/karmada/karmada/test/e2e/framework/deployment.go:82 @ 08/14/24 10:29:40.325

  Full Stack Trace
    github.com/karmada-io/karmada/test/e2e/framework.WaitDeploymentPresentOnClusterFitWith({0xc00053a3a9, 0x7}, {0xc00011fa40, 0x11}, {0xc000d10cc4, 0xc}, 0xc0004a8ab0)
    	/home/runner/work/karmada/karmada/test/e2e/framework/deployment.go:82 +0x614
    github.com/karmada-io/karmada/test/e2e/framework.WaitDeploymentPresentOnClustersFitWith.func1()
    	/home/runner/work/karmada/karmada/test/e2e/framework/deployment.go:100 +0xc5
    github.com/karmada-io/karmada/test/e2e/framework.WaitDeploymentPresentOnClustersFitWith({0xc0009f8200, 0x3, 0x4}, {0xc00011fa40, 0x11}, {0xc000d10cc4, 0xc}, 0xc0004a8ab0)
    	/home/runner/work/karmada/karmada/test/e2e/framework/deployment.go:98 +0x236
    github.com/karmada-io/karmada/test/e2e.glob..func33.1.3.3()
    	/home/runner/work/karmada/karmada/test/e2e/propagationpolicy_test.go:598 +0x35b
    github.com/karmada-io/karmada/test/e2e.glob..func33.1.3()
    	/home/runner/work/karmada/karmada/test/e2e/propagationpolicy_test.go:596 +0x2c7

Copy link
Member

@RainbowMango RainbowMango left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm
/approve

@karmada-bot karmada-bot added the lgtm Indicates that a PR is ready to be merged. label Aug 15, 2024
@karmada-bot
Copy link
Collaborator

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: RainbowMango

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@karmada-bot karmada-bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Aug 15, 2024
@karmada-bot karmada-bot merged commit cc82274 into karmada-io:release-1.10 Aug 15, 2024
12 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. lgtm Indicates that a PR is ready to be merged. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants