Add GitHub tests for karmadactl init --config command #5306
Conversation
karmada-bot
added
the
kind/feature
karmada-bot
added
the
size/L
tiansuo114
changed the title
|
Codecov ReportAll modified and coverable lines are covered by tests ✅
❗ Your organization needs to install the Codecov GitHub app to enable full functionality. Additional details and impacted files@@ Coverage Diff @@
## master #5306 +/- ##
==========================================
+ Coverage 41.64% 41.67% +0.02%
==========================================
Files 653 653
Lines 55484 55518 +34
==========================================
+ Hits 23109 23135 +26
- Misses 30876 30883 +7
- Partials 1499 1500 +1
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
|
May need help😭😭, in my own project's github action, these tests passed correctly, but when I commit, these tests become failed, what should I do to fix these problems |
|
/assign |
|
/ok-to-test |
karmada-bot
added
size/XL
I have fixed the issues you pointed out and provided new e2e test cases. Please let me know if there are any further modifications needed. :) |
|
This PR is related to the documentation PR: #5277 |
Add to PR issue body would be great, thank you!
|
Ok, I modified the pr and the other two questions about pr and added links to it |
|
Ask @zhzhuang-zju have a look. |
karmada-bot
added
the
do-not-merge/contains-merge-commits
karmada-bot
removed
the
do-not-merge/contains-merge-commits
|
#5744 is migration to here (for Summer OSPP 2024) |
|
Based on the OSPP project's requirements, this PR has been reopened. However, the relevant content in this PR has been changed to add automated testing for the new |
tiansuo114
changed the title
|
/hold cancel |
karmada-bot
removed
the
do-not-merge/hold
The code in this PR has been re-pushed and tested, and after a code clean-up, I’ve removed the unnecessary metadata part in KarmadaInitConfig. We can now continue with the previous review.🎉 If need to track this issue, please refer to the relevant changes in this PR. |
There was a problem hiding this comment.
thank you!
/lgtm
/cc @zhzhuang-zju if you want to review for karmadactl
|
@liangyuanpeng: GitHub didn't allow me to request PR reviews from the following users: want, to, review, for, if, you. Note that only karmada-io members and repo collaborators can review this PR, and authors cannot review their own PRs. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
RainbowMango
changed the title
.github/workflows/cli.yaml
Outdated
| uses: actions/upload-artifact@v4 | ||
| with: | ||
| name: karmadactl_config_test_logs_${{ matrix.k8s }} | ||
| path: ${{ github.workspace }}/karmadactl-test-logs/${{ matrix.k8s }}/config/ |
There was a problem hiding this comment.
Do you mean it’s best to add a blank line at the end of the line? If so, the code has already been updated. If I’ve misunderstood, please feel free to correct me.
There was a problem hiding this comment.
Do you mean it’s best to add a blank line at the end of the line?
correct
Signed-off-by: tiansuo114 <1729765480@qq.com>
|
It seems this is the last PR for the summer OSPP program. #5387. |
Yes, this PR is the last one for the OSPP tasks. Up until now, with the merge of this PR into the main branch, all planned PRs have been incorporated into Karmada. |
Yes, it is. |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: liangyuanpeng, RainbowMango The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
karmada-bot
added
the
approved
What type of PR is this?
What this PR does / why we need it:
This PR is an additional test, based on the suggestion provided in url.
Which issue(s) this PR fixes:
Part of #5387
It adds test cases for deploying Karmada services using the
karmadactl init --configcommand with a configuration file, similar to the existing tests forkarmadactl init.Special notes for your reviewer:
@liangyuanpeng
@RainbowMango
This PR currently contains two commits because the test files depend on the new feature for deploying with a configuration file, introduced in #5357. Once that PR is merged, this PR will be rebased, retaining only the commit for adding test cases. However, to save time, it is being submitted for review in advance.Does this PR introduce a user-facing change?: