Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Automated cherry pick of #5252: fix: ClusterResourceBinding scope in #5262

Conversation

XiShanYongYe-Chang
Copy link
Member

@XiShanYongYe-Chang XiShanYongYe-Chang commented Jul 27, 2024

Cherry pick of #5252 on release-1.10.
#5252: fix: ClusterResourceBinding scope in
For details on the cherry pick process, see the cherry pick requests page.

Helm: fix wrong `ClusterResourceBinding` scope in `MutatingWebhookConfiguration`.

Signed-off-by: Amir Alavi <amiralavi7@gmail.com>
@karmada-bot karmada-bot requested review from chaosi-zju and pidb July 27, 2024 01:39
@karmada-bot karmada-bot added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label Jul 27, 2024
@XiShanYongYe-Chang
Copy link
Member Author

/assign @a7i

@codecov-commenter
Copy link

⚠️ Please install the 'codecov app svg image' to ensure uploads and comments are reliably processed by Codecov.

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 53.29%. Comparing base (71fa36a) to head (90c8eaf).

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files
@@               Coverage Diff                @@
##           release-1.10    #5262      +/-   ##
================================================
- Coverage         53.29%   53.29%   -0.01%     
================================================
  Files               253      253              
  Lines             20576    20576              
================================================
- Hits              10967    10966       -1     
- Misses             8882     8883       +1     
  Partials            727      727              
Flag Coverage Δ
unittests 53.29% <ø> (-0.01%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@a7i
Copy link
Contributor

a7i commented Jul 27, 2024

Thank you!
/lgtm

@karmada-bot karmada-bot added the lgtm Indicates that a PR is ready to be merged. label Jul 27, 2024
@XiShanYongYe-Chang
Copy link
Member Author

/assign @RainbowMango

Copy link
Member

@RainbowMango RainbowMango left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/approve

Great thanks to @a7i for digging into this issue.
This is introduced by #4474, obviously lack enough test coverage.

@karmada-bot
Copy link
Collaborator

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: RainbowMango

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@karmada-bot karmada-bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jul 29, 2024
@karmada-bot karmada-bot merged commit d467ca8 into karmada-io:release-1.10 Jul 29, 2024
13 checks passed
@XiShanYongYe-Chang XiShanYongYe-Chang deleted the automated-cherry-pick-of-#5252-upstream-release-1.10 branch August 17, 2024 09:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants