Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix register cluster creates agent missing --cluster-namespace parameter #5005

Merged

Conversation

yanfeng1992
Copy link
Member

@yanfeng1992 yanfeng1992 commented May 30, 2024

Signed-off-by: huangyanfeng huangyanfeng1992@gmail.com

What type of PR is this?
/kind bug

What this PR does / why we need it:

register cluster creates agent deployment missing --cluster-namespace parameter

Which issue(s) this PR fixes:
Fixes #

Special notes for your reviewer:

Does this PR introduce a user-facing change?:

`karmadactl`:  Fix register cluster creates agent missing --cluster-namespace parameter

Signed-off-by: huangyanfeng <huangyanfeng1992@gmail.com>
@karmada-bot karmada-bot added the kind/bug Categorizes issue or PR as related to a bug. label May 30, 2024
@karmada-bot karmada-bot added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label May 30, 2024
@codecov-commenter
Copy link

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 53.31%. Comparing base (eb4a10d) to head (2a10b8b).

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #5005      +/-   ##
==========================================
+ Coverage   53.30%   53.31%   +0.01%     
==========================================
  Files         253      253              
  Lines       20560    20560              
==========================================
+ Hits        10959    10962       +3     
+ Misses       8875     8873       -2     
+ Partials      726      725       -1     
Flag Coverage Δ
unittests 53.31% <ø> (+0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Member

@RainbowMango RainbowMango left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yeah, the option --cluster-namespace of karmadactl register is missed during register.

    --cluster-namespace='karmada-cluster':
	Namespace in the control plane where member cluster secrets are stored.

/lgtm
/approve

@karmada-bot karmada-bot added the lgtm Indicates that a PR is ready to be merged. label May 30, 2024
@karmada-bot
Copy link
Collaborator

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: RainbowMango

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@karmada-bot karmada-bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label May 30, 2024
@karmada-bot karmada-bot merged commit a8c6723 into karmada-io:master May 30, 2024
12 checks passed
@yanfeng1992 yanfeng1992 deleted the fix-register-clusternamespace branch May 31, 2024 02:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. kind/bug Categorizes issue or PR as related to a bug. lgtm Indicates that a PR is ready to be merged. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants