Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: upgrade karmada chart dependency #4829

Merged

Conversation

warjiang
Copy link
Contributor

@warjiang warjiang commented Apr 12, 2024

What type of PR is this?
/kind feature

What this PR does / why we need it:
upgrade bitnami/common dependency in karmada chart
Which issue(s) this PR fixes:
no related issue, but as part of another pr #4785
in this pr, we combine all image secrets together, this is reduce similar code like :

{{/*
Return the proper Docker Image Registry Secret Names
*/}}
{{- define "karmada.agent.imagePullSecrets" -}}
{{ include "common.images.pullSecrets" (dict "images" (list .Values.agent.image) "global" .Values.global) }}
{{- end -}}

but this is introduce another problem, bitnami/common@1.x.x will not handle duplicate secret names in chart, after upgrade it to bitnami/common@2.x.x, it will use uniq to remove duplicate secret names in chart.

more details can refer 👉: bitnami/charts@ddfea70

Special notes for your reviewer:

Does this PR introduce a user-facing change?:

upgrade `bitnami/common` dependency in karmada chart from `1.x.x` to `2.x.x`

Signed-off-by: warjiang <1096409085@qq.com>
@karmada-bot karmada-bot added the kind/feature Categorizes issue or PR as related to a new feature. label Apr 12, 2024
@karmada-bot karmada-bot added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label Apr 12, 2024
@warjiang
Copy link
Contributor Author

/assign @pidb @Poor12

Copy link
Member

@RainbowMango RainbowMango left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm
/approve

@karmada-bot karmada-bot added the lgtm Indicates that a PR is ready to be merged. label Apr 15, 2024
@karmada-bot
Copy link
Collaborator

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: RainbowMango

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@karmada-bot karmada-bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Apr 15, 2024
@karmada-bot karmada-bot merged commit fa079c6 into karmada-io:master Apr 15, 2024
12 of 13 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. kind/feature Categorizes issue or PR as related to a new feature. lgtm Indicates that a PR is ready to be merged. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants