-
Notifications
You must be signed in to change notification settings - Fork 914
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: Add QPS related parameters to control the request rate of metrics-adapter to member clusters. #4809
Conversation
c6c1033
to
13cec72
Compare
/cc @chaosi-zju PTAL. |
we can update the release note |
As a client, adapter has a Burst/QPS limit by default, and when the request volume is too large, it will wait for a long time. However, when the adapter receives too many upstream (karmada-apiserver) requests and its own downstream (member cluster apiserver) requests are restricted, it will cause a backlog of requests, which in turn causes adapter memory to continue to rise. Therefore, by setting a reasonable Burst/QPS parameter, memory rise problem can be avoided. /LGTM |
/kind feature |
13cec72
to
6dde385
Compare
/kind-remove bug |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/assign
…pter to member clusters. Signed-off-by: chaunceyjiang <chaunceyjiang@gmail.com>
6dde385
to
6f29134
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
/approve
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: RainbowMango The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
What type of PR is this?
/kind bug
What this PR does / why we need it:
Add QPS related parameters to control the request rate of metrics-adapter to member clusters.
Which issue(s) this PR fixes:
Fixes #
Special notes for your reviewer:
Does this PR introduce a user-facing change?: