Skip to content

fix: update service failed when reconcile #4649

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Feb 27, 2024

Conversation

laihezhao
Copy link
Contributor

@laihezhao laihezhao commented Feb 23, 2024

What type of PR is this?
/kind bug

What this PR does / why we need it:

I deploy the karmada control plane by karmada-operator

when i modify the karmada CR, I hope the karmada-operator redploy the karmada control plane

But I'm getting the following error

cf83c0d6415d26e66e38f875060e8e57

Which issue(s) this PR fixes:
Fixes #4639

Special notes for your reviewer:

Does this PR introduce a user-facing change?:

`karmada-operator`: Fixed the issue that the component can not be redeployed due to service update is not allowed.

@karmada-bot karmada-bot added the kind/bug Categorizes issue or PR as related to a bug. label Feb 23, 2024
@karmada-bot karmada-bot added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label Feb 23, 2024
@codecov-commenter
Copy link

codecov-commenter commented Feb 23, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 51.46%. Comparing base (f04c17f) to head (0be1a66).

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files
@@           Coverage Diff           @@
##           master    #4649   +/-   ##
=======================================
  Coverage   51.46%   51.46%           
=======================================
  Files         250      250           
  Lines       24951    24951           
=======================================
+ Hits        12840    12842    +2     
+ Misses      11405    11403    -2     
  Partials      706      706           
Flag Coverage Δ
unittests 51.46% <ø> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Comment on lines +110 to +111
service.Spec.ClusterIP = older.Spec.ClusterIP
service.Spec.ClusterIPs = older.Spec.ClusterIPs
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me as we mostly use service with the ClusterIP type, and the IP can not be reset to none.
/assign @calvin0327

@RainbowMango
Copy link
Member

Hi @laihezhao Seems GitHub still recognize you as the first-time contributor, please see the recommendation at #4645 (comment).

Signed-off-by: zhao.laihe <zhao.laihe@neolink.com>
@calvin0327
Copy link

thanks. it's good to me.

/lgtm

@karmada-bot karmada-bot added the lgtm Indicates that a PR is ready to be merged. label Feb 26, 2024
@laihezhao
Copy link
Contributor Author

@RainbowMango #3362 Does the issues will be repaired in v1.9?

Copy link
Member

@RainbowMango RainbowMango left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/approve
I guess @calvin0327 forgot to approve it.

@karmada-bot
Copy link
Collaborator

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: RainbowMango

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@karmada-bot karmada-bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Feb 27, 2024
@karmada-bot karmada-bot merged commit 487f9ca into karmada-io:master Feb 27, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. kind/bug Categorizes issue or PR as related to a bug. lgtm Indicates that a PR is ready to be merged. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Update etcd-client service failed
5 participants