-
Notifications
You must be signed in to change notification settings - Fork 960
fix: update service failed when reconcile #4649
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
❗ Your organization needs to install the Codecov GitHub app to enable full functionality. Additional details and impacted files@@ Coverage Diff @@
## master #4649 +/- ##
=======================================
Coverage 51.46% 51.46%
=======================================
Files 250 250
Lines 24951 24951
=======================================
+ Hits 12840 12842 +2
+ Misses 11405 11403 -2
Partials 706 706
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
service.Spec.ClusterIP = older.Spec.ClusterIP | ||
service.Spec.ClusterIPs = older.Spec.ClusterIPs |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me as we mostly use service with the ClusterIP
type, and the IP can not be reset to none.
/assign @calvin0327
Hi @laihezhao Seems GitHub still recognize you as the |
Signed-off-by: zhao.laihe <zhao.laihe@neolink.com>
thanks. it's good to me. /lgtm |
@RainbowMango #3362 Does the issues will be repaired in v1.9? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/approve
I guess @calvin0327 forgot to approve it.
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: RainbowMango The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
What type of PR is this?
/kind bug
What this PR does / why we need it:
I deploy the karmada control plane by karmada-operator
when i modify the karmada CR, I hope the karmada-operator redploy the karmada control plane
But I'm getting the following error
Which issue(s) this PR fixes:
Fixes #4639
Special notes for your reviewer:
Does this PR introduce a user-facing change?: