-
Notifications
You must be signed in to change notification settings - Fork 875
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add linting for unreachable code #4514
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
❗ Your organization needs to install the Codecov GitHub app to enable full functionality. Additional details and impacted files@@ Coverage Diff @@
## master #4514 +/- ##
==========================================
- Coverage 51.86% 51.85% -0.01%
==========================================
Files 243 243
Lines 24183 24183
==========================================
- Hits 12543 12541 -2
- Misses 10959 10961 +2
Partials 681 681
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
Hi @Affan-7 There is a conflict you need to resolve. |
Signed-off-by: Mohammed Affan <mohammed.affan.727@gmail.com>
eed7fdd
to
d85a32f
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
/approve
I helped rebase the code.
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: RainbowMango The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Thanks! |
What type of PR is this?
/kind cleanup
What this PR does / why we need it:
This PR enables linting for the unreachable code.
Which issue(s) this PR fixes:
Part of #4490
Does this PR introduce a user-facing change?: